Bug 39896 - [V8] DB V8 bindings should not pass empty handles to V8 code
Summary: [V8] DB V8 bindings should not pass empty handles to V8 code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 12:30 PDT by Dumitru Daniliuc
Modified: 2010-06-05 13:40 PDT (History)
4 users (show)

See Also:

Attachments
patch (4.23 KB, patch)
2010-05-28 13:36 PDT, Dumitru Daniliuc 		abarth: review-
dumi: commit-queue-
Details | Formatted Diff | Diff
patch (5.16 KB, patch)
2010-06-04 18:42 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch (5.49 KB, patch)
2010-06-04 19:16 PDT, Dumitru Daniliuc 		abarth: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-05-28 12:30:34 PDT 
Currently, none of the DB V8 bindings check if any of the arguments passed to invokeCallback() is empty. According to Mats Ager, toV8() can sometimes return empty handles, and passing them to invokeCallback() would cause v8 to crash. We should fix that.
Comment 1 Dumitru Daniliuc 2010-05-28 13:36:59 PDT 
Created attachment 57370 [details]
patch
Comment 2 Adam Barth 2010-05-28 14:05:07 PDT 
Comment on attachment 57370 [details]
patch

Test?
Comment 3 Dumitru Daniliuc 2010-06-04 18:42:15 PDT 
Created attachment 57937 [details]
patch
Comment 4 Adam Barth 2010-06-04 18:43:53 PDT 
Comment on attachment 57937 [details]
patch

Hum...  We should add a lot more information to the ChangeLog about why we're doing this in case someone is curious about this rather strange patch.
Comment 5 Dumitru Daniliuc 2010-06-04 19:16:13 PDT 
Created attachment 57946 [details]
patch
Comment 6 Adam Barth 2010-06-04 19:17:27 PDT 
Comment on attachment 57946 [details]
patch

ok, hopefully this will help you gather more useful information
Comment 7 Dumitru Daniliuc 2010-06-05 13:19:41 PDT 
Landed as r60754.
Comment 8 Dumitru Daniliuc 2010-06-05 13:36:26 PDT 
r60755 fixed a typo that caused a build failure.
Comment 9 WebKit Review Bot 2010-06-05 13:40:00 PDT 
http://trac.webkit.org/changeset/60754 might have broken Chromium Mac Release