Added tests for: strokeText fillText strokeLine
Created attachment 57339 [details] Patch to canvas.html
Comment on attachment 57339 [details] Patch to canvas.html In keeping with the C++ style, I would add spaces around the operators. For example here: "500*j/numStrings" WebKitSite/demos/canvas-perf/canvas.html:193 + */ You should get rid of the commented out code. WebKitSite/demos/canvas-perf/canvas.html:226 + */ Ditto.
Created attachment 57350 [details] Patch to canvas.html
Comment on attachment 57350 [details] Patch to canvas.html > + > +function doStrokeTextTests() { > + log("===== StrokeText Tests ====="); > + var strokeTextFunc = function(obj, str, x, y) { obj.strokeText(str, x, y); }; > + for (var i = 1; i < 1001; i *= 10) > + textTest(strokeTextFunc, i); One last comment: It would be nice if these were written in a more async manner to allow for any gc's to happen as done in other tests. Example: function doStrokeTextTests() { log("===== StrokeText Tests ====="); doNextStrokeTextTest(1); } function doNextStrokeTextTest(var lineCount) { var strokeTextFunc = function(canvas, str, x, y) { canvas.strokeText(str, x, y); }; textTest(strokeTextFunc, i); lineCount *= 10; if (lineCount < 1001) window.setTimeout(function () { doNextStrokeTextTest(lineCount); }, idleTimer); else { log(""); window.setTimeout(doFillTextTests, idleTimer); } }
Created attachment 57368 [details] Made the tests more asynchronous
Comment on attachment 57368 [details] Made the tests more asynchronous Please add the beginPath/closePath fix as discussed.
Created attachment 57383 [details] Added beginPath/closePath
Comment on attachment 57383 [details] Added beginPath/closePath Clearing flags on attachment: 57383 Committed r60407: <http://trac.webkit.org/changeset/60407>
All reviewed patches have been landed. Closing bug.