RESOLVED FIXED 39865
[EFL] Set web database path 
https://bugs.webkit.org/show_bug.cgi?id=39865
Summary [EFL] Set web database path
Lucas De Marchi
Reported 2010-05-28 00:57:23 PDT
[EFL] Set web database path
Attachments
Patch (4.71 KB, patch)
2010-05-28 00:58 PDT, Lucas De Marchi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lucas De Marchi
Comment 1 2010-05-28 00:58:22 PDT
Created attachment 57301 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2010-05-28 06:54:04 PDT
Comment on attachment 57301 [details] Patch WebKit/efl/ewk/ewk_main.cpp:119 + ewk_settings_web_database_path_set(getenv("HOME")); Do you really want to store that directly in home?
Gustavo Sverzut Barbieri
Comment 3 2010-05-28 07:47:13 PDT
(In reply to comment #2) > (From update of attachment 57301 [details]) > WebKit/efl/ewk/ewk_main.cpp:119 > + ewk_settings_web_database_path_set(getenv("HOME")); > Do you really want to store that directly in home? Kenneth is right, saving it under ~/.cache/ewebkit is better as some systems may provide cleanup there. Real apps should store that in ${XDG_CONFIG_HOME:-$HOME/.config}/$APP so it is not cleaned. But then we need the $APP to be correct and I'm not sure going with $APP = $ARGV[0] is a good choice, so have a sane default and have the apps to override it.
WebKit Commit Bot
Comment 4 2010-05-28 09:03:38 PDT
Comment on attachment 57301 [details] Patch Clearing flags on attachment: 57301 Committed r60363: <http://trac.webkit.org/changeset/60363>
WebKit Commit Bot
Comment 5 2010-05-28 09:03:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.