Bug 39856 - [Chromium] clicking during a composition cancels it
Summary: [Chromium] clicking during a composition cancels it
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 16:35 PDT by Ojan Vafai
Modified: 2010-06-10 23:54 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-05-27 16:35:08 PDT
It should confirm the composition, not cancel it. I think this might be a (recent?) regression.

1. Type some IME text.
2. Click somewhere else in the editable area.

The text should get confirmed (i.e. lose the underline), instead it's deleted.

Tested on Chrome 6.0.408.1 (Official Build 47574) dev
Comment 1 Tony Chang 2010-05-27 18:24:12 PDT
This is probably a regression caused by the patches in crbug.com/9883.
Comment 2 Tony Chang 2010-05-28 01:36:24 PDT
I am wrong, this is caused by chromium r46856:
http://codereview.chromium.org/1908006

That change explicitly added a cancel composition call on mouse down.  This doesn't seem like the behavior I see when using the OSX IME on other text fields (e.g., in TextEdit).

James, can you investigate?
Comment 3 James Su 2010-05-28 17:42:08 PDT
(In reply to comment #2)
> I am wrong, this is caused by chromium r46856:
> http://codereview.chromium.org/1908006
> 
> That change explicitly added a cancel composition call on mouse down.  This doesn't seem like the behavior I see when using the OSX IME on other text fields (e.g., in TextEdit).
> 
> James, can you investigate?

This is a behavior inherited from the old code. I don't know why it was there. We can remove it if you think it's not correct.
Comment 4 Tony Chang 2010-05-30 17:07:06 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > I am wrong, this is caused by chromium r46856:
> > http://codereview.chromium.org/1908006
> > 
> > That change explicitly added a cancel composition call on mouse down.  This doesn't seem like the behavior I see when using the OSX IME on other text fields (e.g., in TextEdit).
> > 
> > James, can you investigate?
> 
> This is a behavior inherited from the old code. I don't know why it was there. We can remove it if you think it's not correct.

Yes, it appears that clicking should commit the composition rather than cancel it.  This seems to be true whether or not a suggestion is showing.
Comment 5 James Su 2010-06-10 23:53:42 PDT
I reported it in chromium issue tracker: http://code.google.com/p/chromium/issues/detail?id=46326, and I'm working on it.

You may close this bug report.