Bug 39847 - webkit-gtk 1.2.1 won't build on 10.4 Tiger : FastMalloc.cpp:1702: error
Summary: webkit-gtk 1.2.1 won't build on 10.4 Tiger : FastMalloc.cpp:1702: error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (PowerPC) OS X 10.4
: P1 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 10:20 PDT by Eric Le Lay
Modified: 2013-09-11 10:30 PDT (History)
1 user (show)

See Also:

Attachments
patch fixing the compilation error (658 bytes, patch)
2010-05-27 10:20 PDT, Eric Le Lay 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Le Lay 2010-05-27 10:20:27 PDT 
Created attachment 57256 [details]
patch fixing the compilation error

I end up with a compilation error in webkit-1.2.1/JavaScriptCore/wtf/FastMalloc.cpp :

{{{
  CXX    JavaScriptCore/wtf/libJavaScriptCore_la-FastMalloc.lo
JavaScriptCore/wtf/FastMalloc.cpp: In member function 'void WTF::TCMalloc_PageHeap::Carve(WTF::Span*, WTF::Length, bool)':
JavaScriptCore/wtf/FastMalloc.cpp:1702: error: 'free_committed_pages_' was not declared in this scope
make[1]: *** [JavaScriptCore/wtf/libJavaScriptCore_la-FastMalloc.lo] Error 1
make: *** [all] Error 2
}}}

It seems that not all usage of free_committed_pages_ are guarded by USE_BACKGROUND_THREAD_TO_SCAVENGE_MEMORY,
so I removed the guards around its definition.
Comment 1 Alberto Garcia 2013-09-11 10:30:33 PDT 
This is already fixed http://trac.webkit.org/changeset/58355