RESOLVED FIXED39832
Web Inspector: [CRASH] Get CSS rule offsets lazily. 
https://bugs.webkit.org/show_bug.cgi?id=39832
Summary Web Inspector: [CRASH] Get CSS rule offsets lazily.
Pavel Feldman
Reported 2010-05-27 05:57:16 PDT
There is no need to re-parse CSS and get rule offsets unless we start editing. Also: when getting the offsets, create dummy stylesheet with proper owner node - otherwise urls are not resolved and parsing crashes.
Attachments
[PATCH] Proposed fix. (4.44 KB, patch)
2010-05-27 06:04 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-05-27 06:04:13 PDT
Created attachment 57230 [details] [PATCH] Proposed fix.
Yury Semikhatsky
Comment 2 2010-05-27 06:07:52 PDT
Comment on attachment 57230 [details] [PATCH] Proposed fix. WebCore/inspector/InspectorCSSStore.cpp:@ + SourceRange InspectorCSSStore::getStartEndOffsets(CSSStyleRule* rule) Consider removing unused method.
Pavel Feldman
Comment 3 2010-05-27 06:12:57 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/inspector/styles-source-offsets-expected.txt D LayoutTests/inspector/styles-source-offsets.html M WebCore/ChangeLog M WebCore/inspector/InspectorCSSStore.cpp M WebCore/inspector/InspectorDOMAgent.cpp Committed r60297
Pavel Feldman
Comment 4 2010-05-30 23:46:28 PDT
*** Bug 39870 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.