Bug 39829 - [GTK] Implement ThreadSpecific with glib
Summary: [GTK] Implement ThreadSpecific with glib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 04:53 PDT by Kwang Yul Seo
Modified: 2010-06-24 00:47 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2010-05-27 04:56 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (4.04 KB, patch)
2010-05-27 07:17 PDT, Kwang Yul Seo
oliver: review+
oliver: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-05-27 04:53:50 PDT
Implement ThreadSpecific with glib's GStaticPrivate. This patch makes it possible to build GTK port without pthread.
Comment 1 Kwang Yul Seo 2010-05-27 04:56:58 PDT
Created attachment 57224 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-27 06:54:02 PDT
Attachment 57224 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/2526083
Comment 3 Kwang Yul Seo 2010-05-27 07:17:34 PDT
Created attachment 57240 [details]
Patch

Fix the build error.
Comment 4 Eric Seidel (no email) 2010-06-12 20:46:44 PDT
Comment on attachment 57240 [details]
Patch

Cry.  We need to split this out into some sort of ThreadSpecificGtk.h some day.  Otherwise modifications to this file cause full rebuilds of every port. :(
Comment 5 Kwang Yul Seo 2010-06-14 11:05:22 PDT
(In reply to comment #4)
> (From update of attachment 57240 [details])
> Cry.  We need to split this out into some sort of ThreadSpecificGtk.h some day.  Otherwise modifications to this file cause full rebuilds of every port. :(

Okay. This is the same problem as OwnPtrCommon.h. I will file a bug for this once this patch is reviewed.
Comment 6 Eric Seidel (no email) 2010-06-23 15:29:01 PDT
The commit-queue had some hiccups, but this was finally landed as http://trac.webkit.org/changeset/61712
Comment 7 WebKit Review Bot 2010-06-23 16:22:34 PDT
http://trac.webkit.org/changeset/61712 might have broken GTK Linux 64-bit Debug
Comment 8 Kwang Yul Seo 2010-06-23 23:50:58 PDT
(In reply to comment #7)
> http://trac.webkit.org/changeset/61712 might have broken GTK Linux 64-bit Debug

Where can I check the build logs for GTK Linux 64-bit Debug?
Comment 9 Eric Seidel (no email) 2010-06-24 00:47:20 PDT
build.webkit.org has all the bots and logs.  The EWS logs are linked from the EWS bubbles.