Bug 39821 – [EFL] Add Context Menu support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Lucas De Marchi]

Add context menu support in EFL port.

[Lucas De Marchi]

Created attachment 57211 [details]
implement context menu

This is the patch that must be applied after its dependency lands. Please, review #39629.

[Lucas De Marchi]

Created attachment 57314 [details]
Patch

[Lucas De Marchi]

Updated to latest changes and include files in build system.

[Lucas De Marchi]

Comment on attachment 57314 [details]
Patch

Clearing flags to update new version and force style check

[Lucas De Marchi]

Created attachment 57401 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 57401 [details]
Patch

Please take these comments into account

WebCore/platform/efl/ContextMenuEfl.cpp:36
 +          static_cast<ContextMenuClientEfl*>(controller()->client());
Put this on one line please

WebCore/platform/efl/ContextMenuEfl.cpp:45
 +          static_cast<ContextMenuClientEfl*>(controller()->client());
here as well

WebCore/platform/efl/ContextMenuEfl.cpp:75
 +      // Ref counting remains the same, just pass it and remove our ref, so it
ref count remainds the same, that is what you want to say right?

WebCore/platform/efl/ContextMenuItemEfl.cpp:40
 +      // it's inside WebKit that this initialization is done, as WebCore doesn't
Comments start with capital letter and ends with a dot/punctuation mark.

WebKit/efl/WebCoreSupport/ContextMenuClientEfl.h:53
 +      PlatformMenuDescription newPlatformDescription(ContextMenu*);
what about createPlatformDescription ?

WebKit/efl/ewk/ewk_contextmenu.cpp:114
 +      // don't care about title and submenu as they're not used after this point
Capital + dot please

WebKit/efl/ewk/ewk_contextmenu.h:68
 +      // these are new tags! not a part of api!!!!
How so? You should probably make a better comment

[Lucas De Marchi]

Created attachment 57496 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 57496 [details]
Patch

Clearing flags on attachment: 57496

Committed r60454: <http://trac.webkit.org/changeset/60454>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.