Bug 39819 - [Qt] REGRESSION(r60258): It broke 10 tests.
Summary: [Qt] REGRESSION(r60258): It broke 10 tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39700
  Show dependency tree / graph
 
Reported: 2010-05-27 01:08 PDT by Csaba Osztrogonác
Modified: 2010-05-27 12:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2010-05-27 10:54 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Csaba Osztrogonác 2010-05-27 01:31:22 PDT 
I'm on a conference and I can't investigate this regression now,
and I think the author and the reviewer is sleeping now, so I
put the tests into the skipped list temporarily, because we don't
want to block commit queue.

http://trac.webkit.org/changeset/60281
Comment 2 Anders Carlsson 2010-05-27 10:54:59 PDT 
Created attachment 57259 [details]
Patch
Comment 3 Anders Carlsson 2010-05-27 10:55:46 PDT 
Ignore the unrelated WebKit2 patch.
Comment 4 Csaba Osztrogonác 2010-05-27 11:51:59 PDT 
(In reply to comment #2)
> Created an attachment (id=57259) [details]
> Patch

LGTM. I tested this patch (ignoring unrelated WebKit2 changes)
and it works without any regression. It is a good fix, as GTK 
fix landed before: http://trac.webkit.org/changeset/60260

I'd like to give you an r+, but I'm not a reviewer to do it.
Comment 5 Adam Roben (:aroben) 2010-05-27 11:59:35 PDT 
Comment on attachment 57259 [details]
Patch

r=me if you remove the WebKit2 stuff
Comment 6 Anders Carlsson 2010-05-27 12:08:01 PDT 
Committed r60316: <http://trac.webkit.org/changeset/60316>