RESOLVED INVALID 39814
Give FunctionExecutable & NativeExecutable a common parent class. 
https://bugs.webkit.org/show_bug.cgi?id=39814
Summary Give FunctionExecutable & NativeExecutable a common parent class.
Gavin Barraclough
Reported 2010-05-26 23:55:56 PDT
Currently all Executables are derived from ExecutableBase, With FunctionExecutable, EvalExecutable and ProgramExecutable all inheriting via ScriptExecutable (and NativeExecutable directing subclassing ExecutableBase). This means that the executables representing Functions' only ancestor is ExecutableBase, and as such any properties shared between the Executable types representing functions must also be shared with eval and program code too. Fold ScriptExecutable into ExecutableBase, and add a new class, FunctionExecutableBase, into the hierarchy as a common parent to FunctionExecutable and NativeExecutable.
Attachments
The patch (31.33 KB, patch)
2010-05-26 23:57 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-05-26 23:57:23 PDT
Created attachment 57202 [details] The patch
WebKit Review Bot
Comment 2 2010-05-26 23:59:24 PDT
Attachment 57202 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/bytecode/SamplingTool.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/runtime/Executable.h:268: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/runtime/Executable.h:439: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-05-26 23:59:41 PDT
Comment on attachment 57202 [details] The patch r=me
Eric Seidel (no email)
Comment 4 2010-09-02 13:49:21 PDT
I assume this was landed?
Eric Seidel (no email)
Comment 5 2010-12-20 22:35:02 PST
Please re-open if i'm wrong.
Darin Adler
Comment 6 2011-06-18 12:00:08 PDT
Comment on attachment 57202 [details] The patch Clearing review flag on this old patch that was never landed.
Gavin Barraclough
Comment 7 2011-06-18 17:44:12 PDT
Executable has changed significantly since this change was initially proposed (specifically are now GC objects). Killing this bug off, if we do need a change like this in future will roll from scratch.
Note You need to log in before you can comment on or make changes to this bug.