Bug 39810 – new-run-webkit-tests: Support DRT on Chromium-win

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kent Tamura]

See the discussion in https://bugs.webkit.org/show_bug.cgi?id=39203

Summary:
 DRT protocol needs non-blocking file read.
 Windows Python (non-Cygwin) can't set non-blocking mode by fcntl().
 Cygwin Python can do it.


Possible solutions:
 a) Use Cygwin Python
  I tried it.  I needed some cygpath conversion hacks, but still have mysterious hangup.
 b) Use ctypes
  Can we use ReadFileEx() through ctypes.windll.kernel32?
 c) Implement test_shell protocol for Chromium DRT

[Kent Tamura]

Created attachment 57310 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 57310 [details]
Patch

I like this refactoring, it makes management of the output code easier. We should probably do the same thing in the DRT proper -- but not today.


WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:49
 +  # Chromium DRT on non-Windows uses WebKitDriver.
I am curious how platform/win DRT works then?

[Dirk Pranke]

(In reply to comment #2)
> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:49
>  +  # Chromium DRT on non-Windows uses WebKitDriver.
> I am curious how platform/win DRT works then?

I don't think it does. AFAIK, it was only a partial implementation that doesn't fully work yet. Copying abarth, who did the port and probably knows best the status.

[Kent Tamura]

Comment on attachment 57310 [details]
Patch

Clearing flags on attachment: 57310

Committed r60427: <http://trac.webkit.org/changeset/60427>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.