Bug 39810 - new-run-webkit-tests: Support DRT on Chromium-win
Summary: new-run-webkit-tests: Support DRT on Chromium-win
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows Vista
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 28395
  Show dependency treegraph
 
Reported: 2010-05-26 23:18 PDT by Kent Tamura
Modified: 2010-05-30 21:08 PDT (History)
7 users (show)

See Also:


Attachments
Patch (30.07 KB, patch)
2010-05-28 03:10 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-05-26 23:18:54 PDT
See the discussion in https://bugs.webkit.org/show_bug.cgi?id=39203

Summary:
 DRT protocol needs non-blocking file read.
 Windows Python (non-Cygwin) can't set non-blocking mode by fcntl().
 Cygwin Python can do it.


Possible solutions:
 a) Use Cygwin Python
  I tried it.  I needed some cygpath conversion hacks, but still have mysterious hangup.
 b) Use ctypes
  Can we use ReadFileEx() through ctypes.windll.kernel32?
 c) Implement test_shell protocol for Chromium DRT
Comment 1 Kent Tamura 2010-05-28 03:10:48 PDT
Created attachment 57310 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-05-28 07:06:01 PDT
Comment on attachment 57310 [details]
Patch

I like this refactoring, it makes management of the output code easier. We should probably do the same thing in the DRT proper -- but not today.


WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:49
 +  # Chromium DRT on non-Windows uses WebKitDriver.
I am curious how platform/win DRT works then?
Comment 3 Dirk Pranke 2010-05-28 14:02:58 PDT
(In reply to comment #2)
> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:49
>  +  # Chromium DRT on non-Windows uses WebKitDriver.
> I am curious how platform/win DRT works then?

I don't think it does. AFAIK, it was only a partial implementation that doesn't fully work yet. Copying abarth, who did the port and probably knows best the status.
Comment 4 Kent Tamura 2010-05-30 21:08:04 PDT
Comment on attachment 57310 [details]
Patch

Clearing flags on attachment: 57310

Committed r60427: <http://trac.webkit.org/changeset/60427>
Comment 5 Kent Tamura 2010-05-30 21:08:14 PDT
All reviewed patches have been landed.  Closing bug.