UNCONFIRMED 39800
Enable DOMWindow::innerWidth to return a value defined by the platform port 
https://bugs.webkit.org/show_bug.cgi?id=39800
Summary Enable DOMWindow::innerWidth to return a value defined by the platform port
Grace Kloba
Reported 2010-05-26 17:45:26 PDT
In mobile platform, visual viewport and layout viewport can be different. Currently DOMWindow::innerWidth() and etc uses the view->width() which is the layout viewport dimension. Add an abstract layer so that the platform can provide their own version. The default is the current version.
Attachments
first patch (5.22 KB, patch)
2010-05-26 17:56 PDT, Grace Kloba 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grace Kloba
Comment 1 2010-05-26 17:56:45 PDT
Created attachment 57181 [details] first patch
Darin Adler
Comment 2 2010-06-12 18:51:34 PDT
Comment on attachment 57181 [details] first patch This patch seems like the wrong way to go about things. I understand the need to return the right values at the top level of DOMWindow, but I don't see what this has to do with ScrollView. And this doesn't seem to be a platform-specific issue to me, anyway. Maybe someone can give a more concrete explanation of what's going on here and how it's different for Android and for other platforms like iPhone or other mobile phones.
Grace Kloba
Comment 3 2010-06-13 20:26:23 PDT
As pointed out in http://www.quirksmode.org/mobile/viewports2.html, Android was not reporting window.innerWidth() correctly. We try to fix it. We believe most of the mobile browsers have the similar issue. The content is rendered based on the fixed viewport which is different than the physical screen size. Do you have a suggestion on where we should report this different size?
Adam Barth
Comment 4 2010-07-27 08:42:09 PDT
Comment on attachment 57181 [details] first patch This patch appears blocked on getting consensus on the right way to approach this issue. Please feel free to re-nominate when we've got agreement on what we want to do here.
Note You need to log in before you can comment on or make changes to this bug.