Bug 39799 – Update the block of characters that need to go to complex script path

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Jungshik Shin]

The list of blocks of Unicode characters that require complex script code path is outdated. 
In addition, it does not include [U+02E5, U+02E9] (IPA tone letters). They're not combining, but some sequences of those characters require mandatory ligation. 

See  Unicode 5.2 section 7.8 Modifier letters (p.224: Tone letters Figure 
7-7) http://www.unicode.org/versions/Unicode5.2.0/ch07.pdf (p. 27 in the 
PDF). 

My preliminary patch is up at http://codereview.chromium.org/2241005/show

I'll upload it here along with a layout test (if I can make one with a commonly available font on each platform). 

It's a Chromium bug ( http://crbug.com/45013) initially filed as a Chromium OS bug (  http://crosbug.com/3122 )

[Jungshik Shin]

Created attachment 57282 [details]
test file

Lines 2 - 6 contain sequences of IPA tone letters that have to be ligated instead of being rendered separately.

[Jungshik Shin]

Created attachment 61297 [details]
patch (layout test without expected results, change log)

Just to stow away my patch and layout test. Not for review, yet.

[Jungshik Shin]

Created attachment 90148 [details]
updated patch (to Unicode 6.0) 

Updated the patch to list all the 'complex script blocks' in Unicode 6.0. I'll generate the layout test results tomorrow and update the patch again. (at the moment, remote connections to Win/Mac do not work well).

[Jungshik Shin]

Created attachment 90277 [details]
patch with layout test and result

[WebKit Review Bot]

Attachment 90277 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jungshik Shin]

Created attachment 90278 [details]
updated patch with style nits fixed

[Adam Barth]

Comment on attachment 90278 [details]
updated patch with style nits fixed

rs=me

[Simon Fraser (smfr)]

This test is failing on Mac SnowLeopard for me:
"FAIL: The following strings are rendered differently depending on what text-rendering is set to : ˥˧˥"