Bug 39786 - Public GIF decoder fails to mark some images as "done"
Summary: Public GIF decoder fails to mark some images as "done"
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Peter Kasting
URL: http://threeframes.net/
Depends on:
Reported: 2010-05-26 14:55 PDT by Peter Kasting
Modified: 2010-05-26 15:26 PDT (History)
2 users (show)

See Also:

patch v1 (2.42 KB, patch)
2010-05-26 15:01 PDT, Peter Kasting
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2010-05-26 14:55:49 PDT
The open-source GIF decoder has a bug that results in it never marking some GIFs as "done".  The problematic code is effectively:

for (...; bytes remaining > bytes to consume in current state; ...) {
    switch (state) {
    case x:
        if (consuming bytes led to a finished GIF)
            state = gif_done;
    case gif_done:
        return true;  // "success"
return false;  // "need more bytes to continue"

The reason this is a problem is that when we switch the state to gif_done, we don't reset the "bytes to consume" value to 0.  So we go to run through the loop again and find that there are no more bytes in the file, but we want to consume some bytes.  Thus we exit the loop and return false, without ever marking the GIF as "done".

The effect of this is that we erroneously mark these GIFs as having failed, and in some cases fail to properly set things like the repeat count.  Try running Chrome 6.0.408.1 on the URL given in this bug's URL field and note that while the GIFs on the page should all animate indefinitely, most don't until you refresh or reload the page.

The fix here is that instead of setting the state directly, we should use a macro that is used to do all the other state changes, which simultaneously sets the new state and the new "bytes to consume" value (which in this case should be 0).

Patch coming shortly.
Comment 1 Peter Kasting 2010-05-26 15:01:04 PDT
Created attachment 57165 [details]
patch v1

This patch fixes both places that failed to use GETN() to change state: one by using the macro, and the other by eliminating it entirely.  (WebKit uses this code differently than Mozilla did, and marking corrupt GIFs as "failed" won't prevent their display.)
Comment 2 Adam Barth 2010-05-26 15:03:46 PDT
Comment on attachment 57165 [details]
patch v1

I have no idea what this does, but I believe you.  It's too bad we don't have more than one image expert.
Comment 3 Adam Barth 2010-05-26 15:04:13 PDT
Maybe Hyatt has some idea who might know this code better?
Comment 4 Peter Kasting 2010-05-26 15:06:59 PDT
(In reply to comment #3)
> Maybe Hyatt has some idea who might know this code better?

Sadly, I think hyatt and I are the only people to have worked on this, and it was years ago for him.

I probably ought to just gut GIFImageReader.cpp someday and rewrite it from scratch.  It's been a never-ending source of problems.
Comment 5 Peter Kasting 2010-05-26 15:26:55 PDT
Fixed in r60255.