Bug 39782 – notifications: in display+close layout test, should wait for display to close

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Gregg]

The notification spec says display is async; in this test we shouldn't try to close the notification before the display has fired.

[John Gregg]

Created attachment 57177 [details]
Patch

[David Levin]

Comment on attachment 57177 [details]
Patch

> Index: LayoutTests/ChangeLog
> +        notifications: in display+close layout test, expect async events

Your title in the bug is better than this (considering fixing this one to match the bug).

[Yael]

Please note that there is one more issue with the layout tests.
According to the spec at http://dev.w3.org/2006/webapi/WebNotifications/publish (8.2.2) 
"If the fetch algorithm returns error information, fire the error event on the notification object and stop executing this algorithm." 

Since the icon urls in the layout tests don't point to valid icons, almost all the tests should fire an error, or am I missing something?

[John Gregg]

Yael, yes you are correct, it's just that the current test harness for notifications doesn't implement any loading, so I'm just verifying that the icon URL supplied gets passed to the NotificationPresenter.

It would be nice to separate some of the other functionality from the icon loading, so in this case of testing the display and close events, I will change it to have no icon.  It probably makes sense to do that for most of the tests, and then we can isolate the loading success and failure in different tests.

[Yael]

(In reply to comment #4)
> I will change it to have no icon.  It probably makes sense to do that for most of the tests, and then we can isolate the loading success and failure in different tests.

Thanks for making the change.

[John Gregg]

Created attachment 57262 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 57262 [details]
Patch

Clearing flags on attachment: 57262

Committed r60643: <http://trac.webkit.org/changeset/60643>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.