Bug 39778 – [Qt] CookieJarQt.cpp has coding-style errors

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Anders Bakken]

WebCore/platform/qt/CookieJarQt.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/CookieJarQt.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/CookieJarQt.cpp:48:  Declaration has space between type name and * in Frame *frame  [whitespace/declaration] [3]
WebCore/platform/qt/CookieJarQt.cpp:51:  Declaration has space between type name and * in FrameLoader *loader  [whitespace/declaration] [3]
WebCore/platform/qt/CookieJarQt.cpp:125:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 5 in 1 files

[Anders Bakken]

Created attachment 57159 [details]
Patch that fixes the coding style issues

[Petri Ojala]

Qt, QtTriaged

[David Levin]

Comment on attachment 57159 [details]
Patch that fixes the coding style issues

>   No new tests. (OOPS!)
Ditto.

[Anders Bakken]

Created attachment 57954 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 57954 [details]
Patch

Seems silly to not just make this a one-line function call now:
     QNetworkCookieJar* jar = cookieJar(document);
125      return (jar != 0);
 125     return jar;

You could use !!cookieJar(document)
to make it clear that your'e returnign a bool if you like.

[David Levin]

Comment on attachment 57954 [details]
Patch

Please consider Eric's comment.

[Benjamin Poulain]

Anders, what is the status of this?

[Benjamin Poulain]

Created attachment 78255 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 78255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78255&action=review

> WebCore/platform/qt/CookieJarQt.cpp:117
> -    return networkAccessManager(document);
> +    return !!networkAccessManager(document);

It this in the coding style guide?

[Andreas Kling]

Comment on attachment 78255 [details]
Patch

Oh, let's answer Kenneth's question first.

[Benjamin Poulain]

(In reply to comment #9)
> > WebCore/platform/qt/CookieJarQt.cpp:117
> > -    return networkAccessManager(document);
> > +    return !!networkAccessManager(document);
> 
> It this in the coding style guide?

No, it was to address Eric Seidel comment (comment 5).

[WebKit Commit Bot]

Comment on attachment 78255 [details]
Patch

Clearing flags on attachment: 78255

Committed r75334: <http://trac.webkit.org/changeset/75334>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.