WebCore/platform/qt/Localizations.cpp:31: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/Localizations.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/Localizations.cpp:482: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:486: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:490: One line control clauses should not use braces. [whitespace/braces] [4] WebCore/platform/qt/Localizations.cpp:494: One space before end of line comments [whitespace/comments] [5] Total errors found: 6 in 1 files
Created attachment 57154 [details] Patch that fixes the coding style issues
Attachment 57154 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/qt/Localizations.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 57154 [details] Patch that fixes the coding style issues The style error relates to this: https://bugs.webkit.org/show_bug.cgi?id=39787
QtTriaged
Comment on attachment 57154 [details] Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto.
(In reply to comment #3) > (From update of attachment 57154 [details]) > The style error relates to this: > > https://bugs.webkit.org/show_bug.cgi?id=39787 Feel free to fix. Should be pretty easy :)
Created attachment 57896 [details] Patch
Attachment 57896 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/qt/Localizations.cpp:30: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 57896 [details] Patch Clearing flags on attachment: 57896 Committed r60730: <http://trac.webkit.org/changeset/60730>
All reviewed patches have been landed. Closing bug.