Bug 39770 – [Qt] PlatformKeyboardEventQt.cpp has coding-style errors

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Anders Bakken]

WebCore/platform/qt/PlatformKeyboardEventQt.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:43:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:147:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:149:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:153:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:155:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:157:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:159:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:161:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:163:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:165:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:169:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:173:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:175:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:199:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:208:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:310:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:311:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:312:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:322:  One space before end of line comments  [whitespace/comments] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:330:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:403:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:447:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:451:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:455:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:459:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:463:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:467:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:471:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:475:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:479:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:514:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:515:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:516:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:517:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/qt/PlatformKeyboardEventQt.cpp:520:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 36 in 1 files

[Anders Bakken]

Created attachment 57150 [details]
Patch that fixes the coding style issues

[Petri Ojala]

QtTriaged

[David Levin]

Comment on attachment 57150 [details]
Patch that fixes the coding style issues

>   No new tests. (OOPS!)
Ditto.

[Anders Bakken]

Created attachment 57945 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 57945 [details]
Patch

We should fix this to be a hash lookup with some nicer cleaner definition syntax.

[WebKit Commit Bot]

Comment on attachment 57945 [details]
Patch

Clearing flags on attachment: 57945

Committed r60744: <http://trac.webkit.org/changeset/60744>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.