WebCore/platform/qt/PlatformMouseEventQt.cpp:33: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/PlatformMouseEventQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/PlatformMouseEventQt.cpp:68: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:69: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:70: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:71: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:97: Declaration has space between type name and * in QContextMenuEvent *ce [whitespace/declaration] [3] WebCore/platform/qt/PlatformMouseEventQt.cpp:123: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:124: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:125: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/qt/PlatformMouseEventQt.cpp:126: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 11 in 1 files
Created attachment 57149 [details] Patch that fixes the coding style issues
QtTriaged
Comment on attachment 57149 [details] Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto.
Created attachment 57944 [details] Patch
Comment on attachment 57944 [details] Patch Again, very sad about the duplicated code!
Comment on attachment 57944 [details] Patch Rejecting patch 57944 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/qt/PlatformMouseEventQt.cpp Hunk #1 FAILED at 28. Hunk #2 FAILED at 64. Hunk #3 FAILED at 93. Hunk #4 FAILED at 119. 4 out of 4 hunks FAILED -- saving rejects to file WebCore/platform/qt/PlatformMouseEventQt.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3139047
Comment on attachment 57944 [details] Patch Could not upload patch 57944 to rietveld. Rietveld is down or there's a bug in the upload bot. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['/WebKit/WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'post-attachment-to-rietveld', '--force-clean', '--non-interactive', '--parent-command=rietveld-upload-queue', 57944]" exit_code: 1 Last 500 characters of output: d.py", line 143, in _process_patch self._main_sequence.run_and_handle_errors(tool, options, state) File "/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 86, in run_and_handle_errors command.handle_script_error(tool, state, e) File "/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queues.py", line 340, in handle_script_error cls._reject_patch(patch, cls._error_message_for_bug(tool, status_id, script_error)) NameError: global name 'patch' is not defined
(In reply to comment #7) > (From update of attachment 57944 [details]) > Could not upload patch 57944 to rietveld. Rietveld is down or there's a bug in the upload bot. This patch doesn't apply on trunk anymore. Sorry for the noisy error message. I'll fix it.
I have no idea what's going on with this bug, but the patch went in: http://trac.webkit.org/changeset/60743