Bug 39764 - [Qt] ScrollbarThemeQt.cpp has coding-style errors
Summary: [Qt] ScrollbarThemeQt.cpp has coding-style errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-05-26 13:28 PDT by Anders Bakken
Modified: 2010-06-04 23:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch that fixes the coding style issues (4.55 KB, patch)
2010-05-26 14:35 PDT, Anders Bakken
no flags Details | Formatted Diff | Diff
Patch (4.67 KB, patch)
2010-06-04 18:44 PDT, Anders Bakken
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-05-26 13:28:10 PDT
WebCore/platform/qt/ScrollbarThemeQt.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/ScrollbarThemeQt.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/ScrollbarThemeQt.cpp:59:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/platform/qt/ScrollbarThemeQt.cpp:81:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/platform/qt/ScrollbarThemeQt.cpp:125:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/platform/qt/ScrollbarThemeQt.cpp:126:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 6 in 1 files
Comment 1 Anders Bakken 2010-05-26 14:35:28 PDT
Created attachment 57144 [details]
Patch that fixes the coding style issues
Comment 2 Petri Ojala 2010-05-26 21:43:31 PDT
QtTriaged
Comment 3 David Levin 2010-05-27 11:20:09 PDT
Comment on attachment 57144 [details]
Patch that fixes the coding style issues

>   No new tests. (OOPS!)
Ditto.
Comment 4 Anders Bakken 2010-06-04 18:44:34 PDT
Created attachment 57939 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-06-04 22:01:35 PDT
Comment on attachment 57939 [details]
Patch

LGTM.
Comment 6 WebKit Commit Bot 2010-06-04 23:07:17 PDT
Comment on attachment 57939 [details]
Patch

Clearing flags on attachment: 57939

Committed r60737: <http://trac.webkit.org/changeset/60737>
Comment 7 WebKit Commit Bot 2010-06-04 23:07:23 PDT
All reviewed patches have been landed.  Closing bug.