WebCore/platform/qt/TemporaryLinkStubsQt.cpp:35: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:43: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:46: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:47: "Cursor.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:39 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:49: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:51: "GraphicsContext.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:46 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:53: "IntPoint.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:44 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:56: "loader.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:48 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:57: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:69: "Widget.h" already included at WebCore/platform/qt/TemporaryLinkStubsQt.cpp:45 [build/include] [4] WebCore/platform/qt/TemporaryLinkStubsQt.cpp:72: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 12 in 1 files
Created attachment 57141 [details] Patch that fixes the coding style issues
"No new tests. (OOPS!)" issue again.
QtTriaged
Created attachment 57935 [details] Patch
Comment on attachment 57935 [details] Patch I wonder if all these includes are still needed. The Qt port is mature enough it shouldn't really have a TemporaryLinkStubs file anymore.
Comment on attachment 57935 [details] Patch Clearing flags on attachment: 57935 Committed r60734: <http://trac.webkit.org/changeset/60734>
All reviewed patches have been landed. Closing bug.