Bug 39756 - Must not cast between CFNumberRef and CFBooleanRef
Summary: Must not cast between CFNumberRef and CFBooleanRef
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-05-26 11:59 PDT by Eric Carlson
Modified: 2010-05-26 12:08 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.50 KB, patch)
2010-05-26 12:02 PDT, Eric Carlson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-05-26 11:59:00 PDT 
CoreFoundation toll-free bridging assumes that if the value passed to CFBooleanGetValue is not a CFBooleanRef, it is some objc value and calls objc_msgSend to get the -boolValue. 

QTMovieVisualContext::getCGImageOptions adds a CFNumberRef with a value of 1 to a dictionary for a key that is expected to be a CFBoolean, it should add kCFBooleanTrue instead.
Comment 1 Eric Carlson 2010-05-26 11:59:31 PDT 
<rdar://problem/8030739>
Comment 2 Eric Carlson 2010-05-26 12:02:26 PDT 
Created attachment 57124 [details]
proposed patch
Comment 3 Eric Carlson 2010-05-26 12:08:18 PDT 
http://trac.webkit.org/changeset/60245