RESOLVED FIXED 39756
Must not cast between CFNumberRef and CFBooleanRef
https://bugs.webkit.org/show_bug.cgi?id=39756
Summary Must not cast between CFNumberRef and CFBooleanRef
Eric Carlson
Reported 2010-05-26 11:59:00 PDT
CoreFoundation toll-free bridging assumes that if the value passed to CFBooleanGetValue is not a CFBooleanRef, it is some objc value and calls objc_msgSend to get the -boolValue. QTMovieVisualContext::getCGImageOptions adds a CFNumberRef with a value of 1 to a dictionary for a key that is expected to be a CFBoolean, it should add kCFBooleanTrue instead.
Attachments
proposed patch (1.50 KB, patch)
2010-05-26 12:02 PDT, Eric Carlson
mitz: review+
Eric Carlson
Comment 1 2010-05-26 11:59:31 PDT
Eric Carlson
Comment 2 2010-05-26 12:02:26 PDT
Created attachment 57124 [details] proposed patch
Eric Carlson
Comment 3 2010-05-26 12:08:18 PDT
Note You need to log in before you can comment on or make changes to this bug.