Bug 39748 – Clean up IndexedDB layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

Clean up IndexedDB layout tests

[Jeremy Orlow]

Created attachment 57111 [details]
Patch

[Andrei Popescu]

I think you have some indentation errors in LayoutTests/storage/indexeddb/resources/shared.js : lines 34, 43 and 52.

Also, do you need a new line at the end of file?

[Jeremy Orlow]

Created attachment 57227 [details]
Patch

[Andrei Popescu]

LGTM

[Steve Block]

Comment on attachment 57227 [details]
Patch

LayoutTests/storage/indexeddb/resources/shared.js:4
 +          layoutTestController.dumpAsText();
This isn't needed - it's in js-test-pre.js

LayoutTests/storage/indexeddb/resources/shared.js:67
 +  \ No newline at end of file
newline

LayoutTests/storage/indexeddb/resources/shared.js:8
 +      shouldBeTrue("'indexedDB' in window");
Is this needed here? It seems like it should be tested in the fast/dom/Window/window-properties* tests.

If we remove this, we can remove the init() function and just call layoutTestController.waitUntilDone() directly.

[Jeremy Orlow]

(In reply to comment #5)
> (From update of attachment 57227 [details])
> LayoutTests/storage/indexeddb/resources/shared.js:4
>  +          layoutTestController.dumpAsText();
> This isn't needed - it's in js-test-pre.js

done

 
> LayoutTests/storage/indexeddb/resources/shared.js:67
>  +  \ No newline at end of file
> newline

done
 
> LayoutTests/storage/indexeddb/resources/shared.js:8
>  +      shouldBeTrue("'indexedDB' in window");
> Is this needed here? It seems like it should be tested in the fast/dom/Window/window-properties* tests.

Since it's behind a compile flag, the window properties tests skip over indexedDB..and that'll be true until the majority of the tests enable it.  Also tests like dom storage run this check every single time.  But I guess we could split it into its own test. 
 
> If we remove this, we can remove the init() function and just call layoutTestController.waitUntilDone() directly.

...with the if statement, but OK...we can do that.

[Jeremy Orlow]

Created attachment 57236 [details]
Patch

[Steve Block]

Comment on attachment 57236 [details]
Patch

LayoutTests/storage/indexeddb/script-tests/idb-database-request.js:3
 +      layoutTestController.waitUntilDone();
Actually, I meant that you could leave this call in shared.js, but not in a function, so as to avoid the need to call that function from each test's JS file.

[Jeremy Orlow]

Committed r60299: <http://trac.webkit.org/changeset/60299>