Bug 39711 - provide parsed view of get params
Summary: provide parsed view of get params
Status: RESOLVED DUPLICATE of bug 20628
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 23:13 PDT by mbrevda
Modified: 2011-02-03 09:36 PST (History)
3 users (show)

See Also:


Attachments
firebug demo (81.41 KB, image/png)
2010-05-25 23:20 PDT, mbrevda
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mbrevda 2010-05-25 23:13:41 PDT
Firebug parses the sent parms, as well as any responce (think: json) so that they can be viewed in a clean key:value table. This is in addition to the raw request url and response, making finding the value your looking for simpler. Would be nice to have this as well!
Comment 1 mbrevda 2010-05-25 23:20:29 PDT
Created attachment 57074 [details]
firebug demo
Comment 3 Patrick Mueller 2010-05-26 11:19:36 PDT
This was previously implemented via Bug 22920; perhaps there's at least some code to reuse there, if it's been removed since.
Comment 4 Patrick Mueller 2010-05-27 08:00:17 PDT
I tried the test case 

    WebKit/WebCore/manual-tests/inspector/display-form-data.html

which is the test case for Bug 22920, on nightly r60266.  All tests appear to pass.

Trying that test on Chrome/Mac 6.0.408.1 dev shows multiple problems:

- test-2 does not show any query string parameters when it should
- the tests get an uncaught error during an XHR request, which causes later tests to fail

The tests currently do sync- and async- XHR testing, since I figured the control paths under the covers would be a little different, and I wanted to make sure we covered those cases.  Perhaps we need to put some kind of guard around the sync- versions.  Or perhaps the fact that tests all send requests to http://example.org is part of the problem, which end up generating 404 status codes.

Not quite ready to mark this as WORKSFORME, and just say this is a Chrome problem, and not a WebKit problem.  Doing a little more investigation ...
Comment 5 Patrick Mueller 2010-05-27 08:18:43 PDT
- commenting out the sync- calls gets you a bit further than calling them.

- running the file against a real server gets you a bit further than running against a file:// url.

Still, the best I can do, I don't see all of the data the tests expect.  It appears the query string params are the biggest problem.  I think perhaps we need to refresh the query string params in different/additional places to get Chrome to display them.

I think we need to change this test to run against a real server, and should see if we can run the sync- tests in timer events, to eliminate the general Xhr issues when running in Chrome.
Comment 6 Pavel Feldman 2010-05-27 10:43:39 PDT
Patrick, what you are describing is just a regression, it affects both WebKit and Chromium. I fixed it under: https://bugs.webkit.org/show_bug.cgi?id=39848.

As a result, we show GET query parameters + Post payload + form data. We do not response as JSON as this bug requests, so I am leaving it opened.
Comment 7 Patrick Mueller 2010-05-27 11:57:11 PDT
(In reply to comment #6)

> We do not response as JSON as this bug requests, so I am leaving it opened.

Let's close it as a DUP of Bug 37488 instead, if all that's left is JSON display of the response (and presumably the request)
Comment 8 Patrick R. Gansterer 2011-02-03 09:36:47 PST

*** This bug has been marked as a duplicate of bug 20628 ***