Bug 39706 – Make more HTML DOM members private, especially constructors, batch 2

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

Make more HTML DOM members private, especially constructors, batch 2

[Darin Adler]

Created attachment 57064 [details]
Patch

[David Levin]

Comment on attachment 57064 [details]
Patch

WebCore/html/HTMLKeygenElement.cpp:52
 +          RefPtr<HTMLOptionElement> o = HTMLOptionElement::create(optionTag, document, this->form());
Consider adding a constructor for HTMLOptionElement which doesn't need to be passed "optionTag" as you did in other places in this patch and the previous one.



WebCore/html/HTMLOptGroupElement.cpp: 
 +      bool result = HTMLFormControlElement::insertBefore(newChild, refChild, ec, shouldLazyAttach);
I wonder if "HTMLFormControlElement::insertBefore" is used anywhere now (ditto for the other method calls that were removed here).

[Darin Adler]

(In reply to comment #2)
> (From update of attachment 57064 [details])
> WebCore/html/HTMLKeygenElement.cpp:52
>  +          RefPtr<HTMLOptionElement> o = HTMLOptionElement::create(optionTag, document, this->form());
> Consider adding a constructor for HTMLOptionElement which doesn't need to be passed "optionTag" as you did in other places in this patch and the previous one.

I'll do that.

> WebCore/html/HTMLOptGroupElement.cpp: 
>  +      bool result = HTMLFormControlElement::insertBefore(newChild, refChild, ec, shouldLazyAttach);
> I wonder if "HTMLFormControlElement::insertBefore" is used anywhere now (ditto for the other method calls that were removed here).

I'm not sure I understand your question or suggestion here. These were unnecessary virtual function overrides that did nothing but call through to the parent class. I removed them. But the functions themselves are still used.

[David Levin]

(In reply to comment #3)
> > WebCore/html/HTMLOptGroupElement.cpp: 
> >  +      bool result = HTMLFormControlElement::insertBefore(newChild, refChild, ec, shouldLazyAttach);
> > I wonder if "HTMLFormControlElement::insertBefore" is used anywhere now (ditto for the other method calls that were removed here).
> 
> I'm not sure I understand your question or suggestion here. These were unnecessary virtual function overrides that did nothing but call through to the parent class. I removed them. But the functions themselves are still used.

You answered it.

 I thought that maybe the functions were unused and now the functions that they called were unused.

(Sorry about taking so long to reply. I never saw your comment. When you review something, you don't get added to the cc list automatically unlike when you just leave a comment like this.)

[Darin Adler]

(In reply to comment #4)
> (Sorry about taking so long to reply.

You took less than an hour to reply!

> I never saw your comment. When you review something, you don't get added to the cc list automatically unlike when you just leave a comment like this.)

Yes, I noticed that too. As you are aware I do a lot of reviews, so I am often affected by this. I guess we should change it.

[Darin Adler]

Committed r60361: <http://trac.webkit.org/changeset/60361>

[WebKit Review Bot]

http://trac.webkit.org/changeset/60361 might have broken GTK Linux 64-bit Release