Bug 39684 - Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp
Summary: Remove obsolete code from WebKit/chromium/src/FrameLoaderClientImpl.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Brett Wilson (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 12:58 PDT by Brett Wilson (Google)
Modified: 2010-05-26 14:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2010-05-25 13:01 PDT, Brett Wilson (Google) 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
New patch (1.84 KB, patch)
2010-05-25 13:04 PDT, Brett Wilson (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2010-05-25 12:58:19 PDT 
The #if !OS(WINDOWS) block in FrameLoaderClientImpl.::createPlugin appears to no longer be necessary and is preventing some things from working.
Comment 1 Brett Wilson (Google) 2010-05-25 13:01:43 PDT 
Created attachment 57038 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-05-25 13:03:23 PDT 
Comment on attachment 57038 [details]
Patch

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 8593698..5fffb0d 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,14 @@
> +2010-05-25  Brett Wilson  <brettw@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Remove obsolete code for Mac & Windows plugin creation in the Chromium
> +        port. This non-Windows code was to prevent a crash which we no longer
> +        seem to have, and it is preventing other types of plugins from working.
> +

Add a bug reference here.

R=me
Comment 3 Brett Wilson (Google) 2010-05-25 13:04:46 PDT 
Created attachment 57039 [details]
New patch
Comment 4 Brett Wilson (Google) 2010-05-25 13:14:11 PDT 
Fixed in r60178
Comment 5 Nico Weber 2010-05-26 14:09:32 PDT 
I wanted to remove that today too, to get the default plugin loading on mac and linux. Thanks :-)