Bug 39679 - Add callbacks to ScriptController to allow notifications on named items additions and removals
Summary: Add callbacks to ScriptController to allow notifications on named items addit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 10:54 PDT by anton muhin
Modified: 2010-05-27 05:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.88 KB, patch)
2010-05-25 10:59 PDT, anton muhin 		no flags Details | Formatted Diff | Diff
fixing const declaration for JSC (4.89 KB, patch)
2010-05-25 11:18 PDT, anton muhin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-05-25 10:54:06 PDT 
Add callbacks to ScriptController to allow notifications on named items additions and removals
Comment 1 anton muhin 2010-05-25 10:59:25 PDT 
Created attachment 57030 [details]
Patch
Comment 2 anton muhin 2010-05-25 11:00:42 PDT 
This change allows to get rid of interceptor on HTMLDocument and thus provide faster access to properties.
Comment 3 Early Warning System Bot 2010-05-25 11:13:24 PDT 
Attachment 57030 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/2280585
Comment 4 anton muhin 2010-05-25 11:18:01 PDT 
Created attachment 57033 [details]
fixing const declaration for JSC
Comment 5 Adam Barth 2010-05-26 10:35:34 PDT 
Comment on attachment 57033 [details]
fixing const declaration for JSC

WebCore/bindings/js/ScriptController.h:145
 +      void namedItemAdded(HTMLDocument*, const AtomicString&) { }
I don't get it.  These functions don't do anything.
Comment 6 anton muhin 2010-05-26 10:37:38 PDT 
(In reply to comment #5)
> (From update of attachment 57033 [details])
> WebCore/bindings/js/ScriptController.h:145
>  +      void namedItemAdded(HTMLDocument*, const AtomicString&) { }
> I don't get it.  These functions don't do anything.

Yes.  I've got a next patch, but I need V8 roll to enable it for V8 bindings.

I tried to follow the protocol:

1) add generic interface;
2) add implementation for bindings.

If you prefer to see two patches blended, I can do it in a second.
Comment 7 Adam Barth 2010-05-26 11:03:50 PDT 
Comment on attachment 57033 [details]
fixing const declaration for JSC

Ok.  It's a bit hard to see where this is going, but this patch seems harmless as written...
Comment 8 anton muhin 2010-05-26 11:05:56 PDT 
Comment on attachment 57033 [details]
fixing const declaration for JSC

Thanks a lot, Adam, cq+'ing it.  I'll cc you on next patch (when both WebKit and V8 get rolled into Chromium and stay for a day.)
Comment 9 WebKit Commit Bot 2010-05-27 05:01:11 PDT 
Comment on attachment 57033 [details]
fixing const declaration for JSC

Clearing flags on attachment: 57033

Committed r60291: <http://trac.webkit.org/changeset/60291>
Comment 10 WebKit Commit Bot 2010-05-27 05:01:16 PDT 
All reviewed patches have been landed.  Closing bug.