Bug 39679 – Add callbacks to ScriptController to allow notifications on named items additions and removals

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[anton muhin]

Add callbacks to ScriptController to allow notifications on named items additions and removals

[anton muhin]

Created attachment 57030 [details]
Patch

[anton muhin]

This change allows to get rid of interceptor on HTMLDocument and thus provide faster access to properties.

[Early Warning System Bot]

Attachment 57030 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/2280585

[anton muhin]

Created attachment 57033 [details]
fixing const declaration for JSC

[Adam Barth]

Comment on attachment 57033 [details]
fixing const declaration for JSC

WebCore/bindings/js/ScriptController.h:145
 +      void namedItemAdded(HTMLDocument*, const AtomicString&) { }
I don't get it.  These functions don't do anything.

[anton muhin]

(In reply to comment #5)
> (From update of attachment 57033 [details])
> WebCore/bindings/js/ScriptController.h:145
>  +      void namedItemAdded(HTMLDocument*, const AtomicString&) { }
> I don't get it.  These functions don't do anything.

Yes.  I've got a next patch, but I need V8 roll to enable it for V8 bindings.

I tried to follow the protocol:

1) add generic interface;
2) add implementation for bindings.

If you prefer to see two patches blended, I can do it in a second.

[Adam Barth]

Comment on attachment 57033 [details]
fixing const declaration for JSC

Ok.  It's a bit hard to see where this is going, but this patch seems harmless as written...

[anton muhin]

Comment on attachment 57033 [details]
fixing const declaration for JSC

Thanks a lot, Adam, cq+'ing it.  I'll cc you on next patch (when both WebKit and V8 get rolled into Chromium and stay for a day.)

[WebKit Commit Bot]

Comment on attachment 57033 [details]
fixing const declaration for JSC

Clearing flags on attachment: 57033

Committed r60291: <http://trac.webkit.org/changeset/60291>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.