Add ISSL and ISocket to the list of OwnPtr-ed type.
Created attachment 57003 [details] Patch ISocket and ISSL are used to implement SocketStream.
Attachment 57003 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/brew/OwnPtrBrew.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 57004 [details] Patch Style fix.
Comment on attachment 57004 [details] Patch OK.
Comment on attachment 57004 [details] Patch Rejecting patch 57004 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html
Created attachment 57996 [details] Patch Add missing ChangeLog.
Comment on attachment 57004 [details] Patch Cleared Eric Seidel's review+ from obsolete attachment 57004 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 57996 [details] Patch OK.
Comment on attachment 57996 [details] Patch Clearing flags on attachment: 57996 Committed r60787: <http://trac.webkit.org/changeset/60787>
All reviewed patches have been landed. Closing bug.
Turns out OwnPtrCommon.h is a really bad design. This changed needlessly caused all ports to do full rebuilds. We should change OwnPtrCommon to include platform-specific headers instead.
(In reply to comment #11) > Turns out OwnPtrCommon.h is a really bad design. > > This changed needlessly caused all ports to do full rebuilds. > > We should change OwnPtrCommon to include platform-specific headers instead. I agree. I will file a bug to change OwnPtrCommon to include platform-specific headers. We need to add only Win32 and Brew MP headers for now.