Bug 39666 - [GTK] writeToFile fails when length is large
Summary: [GTK] writeToFile fails when length is large
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 02:48 PDT by Kwang Yul Seo
Modified: 2010-05-27 02:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2010-05-25 02:50 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-05-25 02:48:41 PDT 
writeToFile forgot to increment data pointer.
Comment 1 Kwang Yul Seo 2010-05-25 02:50:22 PDT 
Created attachment 56998 [details]
Patch
Comment 2 Xan Lopez 2010-05-25 11:20:38 PDT 
Comment on attachment 56998 [details]
Patch

My Goodness... good catch.
Comment 3 Xan Lopez 2010-05-25 11:23:02 PDT 
How did you notice this btw? If you have some kind of test it would be really good to add it.
Comment 4 Kwang Yul Seo 2010-05-25 11:28:00 PDT 
(In reply to comment #3)
> How did you notice this btw? If you have some kind of test it would be really good to add it.

I just read the code.
Comment 5 WebKit Commit Bot 2010-05-27 02:52:06 PDT 
Comment on attachment 56998 [details]
Patch

Clearing flags on attachment: 56998

Committed r60286: <http://trac.webkit.org/changeset/60286>
Comment 6 WebKit Commit Bot 2010-05-27 02:52:10 PDT 
All reviewed patches have been landed.  Closing bug.