Bug 39665 - Clean up chromium-specific code from json_results_generator.py
Summary: Clean up chromium-specific code from json_results_generator.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 38693
  Show dependency treegraph
 
Reported: 2010-05-25 02:47 PDT by Kinuko Yasuda
Modified: 2010-06-04 11:19 PDT (History)
3 users (show)

See Also:


Attachments
Proposing patch (8.02 KB, patch)
2010-05-25 03:09 PDT, Kinuko Yasuda
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-05-25 02:47:25 PDT
json_results_generator.py includes a few lines of chromium-specific code (getting chromium's svn path via port and store it into the output JSON file) but no code outside of ChromiumPort should ever need to (according to eseidel https://bugs.webkit.org/show_bug.cgi?id=38693#c2).

Probably the chromium-specific code should be moved to port/chromium.py.
Comment 1 Kinuko Yasuda 2010-05-25 03:09:31 PDT
Created attachment 57000 [details]
Proposing patch
Comment 2 Dirk Pranke 2010-05-26 15:48:06 PDT
Comment on attachment 57000 [details]
Proposing patch

I'm not a reviewer, but this looks good to me.
Comment 3 Shinichiro Hamaji 2010-06-02 23:57:50 PDT
Comment on attachment 57000 [details]
Proposing patch

Putting r+ per Dirk's comment. Please make sure this code still works on non-chromium Mac before you land.
Comment 4 Kinuko Yasuda 2010-06-04 11:19:20 PDT
Committed r60690: <http://trac.webkit.org/changeset/60690>