RESOLVED FIXED Bug 39665
Clean up chromium-specific code from json_results_generator.py 
https://bugs.webkit.org/show_bug.cgi?id=39665
Summary Clean up chromium-specific code from json_results_generator.py
Kinuko Yasuda
Reported 2010-05-25 02:47:25 PDT
json_results_generator.py includes a few lines of chromium-specific code (getting chromium's svn path via port and store it into the output JSON file) but no code outside of ChromiumPort should ever need to (according to eseidel https://bugs.webkit.org/show_bug.cgi?id=38693#c2). Probably the chromium-specific code should be moved to port/chromium.py.
Attachments
Proposing patch (8.02 KB, patch)
2010-05-25 03:09 PDT, Kinuko Yasuda 		hamaji: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2010-05-25 03:09:31 PDT
Created attachment 57000 [details] Proposing patch
Dirk Pranke
Comment 2 2010-05-26 15:48:06 PDT
Comment on attachment 57000 [details] Proposing patch I'm not a reviewer, but this looks good to me.
Shinichiro Hamaji
Comment 3 2010-06-02 23:57:50 PDT
Comment on attachment 57000 [details] Proposing patch Putting r+ per Dirk's comment. Please make sure this code still works on non-chromium Mac before you land.
Kinuko Yasuda
Comment 4 2010-06-04 11:19:20 PDT
Committed r60690: <http://trac.webkit.org/changeset/60690>
Note You need to log in before you can comment on or make changes to this bug.