Bug 39661 - Switch HTML parsing benchmark to use document.write instead of innerHTML
Summary: Switch HTML parsing benchmark to use document.write instead of innerHTML
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 01:41 PDT by Adam Barth
Modified: 2010-05-25 05:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2010-05-25 01:43 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-25 01:41:50 PDT 
Switch HTML parsing benchmark to use document.write instead of innerHTML
Comment 1 Adam Barth 2010-05-25 01:43:15 PDT 
Created attachment 56990 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-05-25 01:44:31 PDT 
Comment on attachment 56990 [details]
Patch

OK.  How does the performance compare with the original benchmark?  Are we still spending a similar amount of time in the tokenizer/parser?  Please comment before landing.
Comment 3 Adam Barth 2010-05-25 01:59:58 PDT 
Comment on attachment 56990 [details]
Patch

Yeah, it's still spending 10% of its time in parseTag (and 42% in functions below that).
Comment 4 WebKit Commit Bot 2010-05-25 05:55:27 PDT 
Comment on attachment 56990 [details]
Patch

Clearing flags on attachment: 56990

Committed r60157: <http://trac.webkit.org/changeset/60157>
Comment 5 WebKit Commit Bot 2010-05-25 05:55:33 PDT 
All reviewed patches have been landed.  Closing bug.