Bug 39655 - [v8] The 'prototype' property on generated Web IDL interfaces should be { DontDelete | ReadOnly }.
Summary: [v8] The 'prototype' property on generated Web IDL interfaces should be { Don...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 00:45 PDT by Tony Chang
Modified: 2011-08-09 21:52 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2011-08-08 05:31 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff
Updates binding test expected results. (6.96 KB, patch)
2011-08-08 16:44 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-05-25 00:45:33 PDT
JSC changed behavior in http://trac.webkit.org/changeset/60119.  This is causing the layout test fast/dom/prototype-property.html to fail.
Comment 1 Tony Chang 2010-05-25 00:55:41 PDT
I'm going to mark the test as failing for now so I can roll WebKit DEPS.
Comment 2 Tony Chang 2010-05-26 00:00:56 PDT
vitalyr has been volunteered to look at this :)
Comment 3 Dominic Cooney 2011-06-16 04:07:43 PDT
For reference, the relevant part of the Web IDL spec is <http://dev.w3.org/2006/webapi/WebIDL/#interface-object> which says:

The interface object must also have a property named prototype with attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } whose value is an object called the interface prototype object.
Comment 4 Dominic Cooney 2011-06-16 06:42:47 PDT
I have filed V8 issue 1479 for the desired API changes on the V8 side. <http://code.google.com/p/v8/issues/detail?id=1479>
Comment 5 Dominic Cooney 2011-07-05 06:34:39 PDT
I believe there is another blocking bug on the V8 side; I have filed <http://code.google.com/p/v8/issues/detail?id=1539> for it.
Comment 6 Dominic Cooney 2011-08-08 05:31:35 PDT
Created attachment 103232 [details]
Patch
Comment 7 Dominic Cooney 2011-08-08 16:44:17 PDT
Created attachment 103313 [details]
Updates binding test expected results.
Comment 8 WebKit Review Bot 2011-08-09 21:52:05 PDT
Comment on attachment 103313 [details]
Updates binding test expected results.

Clearing flags on attachment: 103313

Committed r92747: <http://trac.webkit.org/changeset/92747>
Comment 9 WebKit Review Bot 2011-08-09 21:52:11 PDT
All reviewed patches have been landed.  Closing bug.