Patch to be uploaded.
Created attachment 56959 [details] Patch
Comment on attachment 56959 [details] Patch WebCore/rendering/RenderMenuList.h:104 > + virtual void selectionChanged(unsigned, bool) {} nit: please give these parameters some names. the type names alone do not adequately describe their purpose. WebCore/rendering/RenderTextControlSingleLine.h:111 > + virtual void selectionChanged(unsigned, bool) {} nit: please give these parameters some names. the type names alone do not adequately describe their purpose. WebKit/chromium/src/AutoFillPopupMenuClient.cpp:102 + // FIXME: Refactor this method. nit: please be a bit more descriptive with this comment. if someone else is reading this, it'd be great to not have to guess what you had in mind. i'm not sure what you intend to refactor ;-) WebKit/chromium/src/SuggestionsPopupMenuClient.h:64 + virtual void selectionChanged(unsigned, bool) {} nit: please give these parameters some names... otherwise, LGTM.
(In reply to comment #2) > (From update of attachment 56959 [details]) > WebCore/rendering/RenderMenuList.h:104 > > + virtual void selectionChanged(unsigned, bool) {} > nit: please give these parameters some names. the type names alone > do not adequately describe their purpose. > Done. > WebCore/rendering/RenderTextControlSingleLine.h:111 > > + virtual void selectionChanged(unsigned, bool) {} > nit: please give these parameters some names. the type names alone > do not adequately describe their purpose. > Done. > WebKit/chromium/src/AutoFillPopupMenuClient.cpp:102 > + // FIXME: Refactor this method. > nit: please be a bit more descriptive with this comment. if someone else > is reading this, it'd be great to not have to guess what you had in mind. > i'm not sure what you intend to refactor ;-) > Done. > WebKit/chromium/src/SuggestionsPopupMenuClient.h:64 > + virtual void selectionChanged(unsigned, bool) {} > nit: please give these parameters some names... > > otherwise, LGTM. Done.
Created attachment 57588 [details] Patch
Attachment 57588 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/2795065
Created attachment 57592 [details] Patch
Removed param names from the methods that left the params unused -> build fix.
Committed r60514: <http://trac.webkit.org/changeset/60514>
http://trac.webkit.org/changeset/60514 might have broken Chromium Win Release
Comment on attachment 57592 [details] Patch This was already committed, right? Clearing the review flag.