Bug 39619 – Silence GCC warning

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anders Bakken]

Created attachment 56926 [details]
Patch to silence GCC warning

GCC complains about these kinds of statements:

if (foo || bar && barfood)
    foobar();

suggest parentheses around && within ||

[WebKit Review Bot]

Attachment 56926 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Bakken]

Created attachment 56931 [details]
Patch to silence GCC warning

[Darin Adler]

Comment on attachment 56931 [details]
Patch to silence GCC warning

> +        GCC suggest parentheses around�&&�within�||

Looks like you pasted some non-ASCII characters here. We can't land the ChangeLog like this, so review-. Change is otherwise fine.

[Anders Bakken]

Created attachment 56941 [details]
Patch to silence GCC warning

[WebKit Commit Bot]

Comment on attachment 56941 [details]
Patch to silence GCC warning

Clearing flags on attachment: 56941

Committed r60152: <http://trac.webkit.org/changeset/60152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.