Only if the column-span is an immediate child of the multicol block in this first step...
Created attachment 56924 [details] Patch
Attachment 56924 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderBlock.cpp:280: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/rendering/RenderBlock.cpp:368: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 56927 [details] Patch
Created attachment 56965 [details] Patch Address Dan's comments, clean up typos in changelog.
Created attachment 57001 [details] Patch
Created attachment 57044 [details] Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method
Comment on attachment 57044 [details] Minor tweak - drop toRenderBlock casts when asking isAnonymousColumnSpanBlock, since I made it a RenderObject method WebCore/rendering/RenderBlock.cpp:287 + RenderBlock* newBox = 0; You don’t need to initialize this to 0. Or you could initialize it with a ternary operator. WebCore/rendering/RenderBlock.cpp:311 + RenderBlock* newBox = 0; Ditto. Everything else is scary but fine. r=me
Landed in r60201.
(In reply to comment #8) > Landed in r60201. Buildfix for this patch landed in r60221. ( build without ENABLE(RUBY) )