Bug 39614 - autoinstall DEBUG logging is too chatty
Summary: autoinstall DEBUG logging is too chatty
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 13:38 PDT by Eric Seidel (no email)
Modified: 2010-05-24 14:10 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-05-24 13:38:51 PDT
autoinstall DEBUG logging is too chatty

I don't need this much information:

webkitpy.common.system.autoinstall: [DEBUG] Checking ClientForm.py URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/clientform/.ClientForm.py.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for ClientForm.py already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://pypi.python.org/packages/source/C/ClientForm/ClientForm-0.2.10.zip"
webkitpy.common.system.autoinstall: [DEBUG] Checking mechanize URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.mechanize.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for mechanize already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://pypi.python.org/packages/source/m/mechanize/mechanize-0.1.11.zip"
webkitpy.common.system.autoinstall: [DEBUG] Checking pep8.py URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/.pep8.py.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for pep8.py already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://pypi.python.org/packages/source/p/pep8/pep8-0.5.0.tar.gz#md5=512a818af9979290cd619cce8e9c2e2b"
webkitpy.common.system.autoinstall: [DEBUG] Checking upload.py URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/rietveld/.upload.py.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for upload.py already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://webkit-rietveld.googlecode.com/svn/trunk/static/upload.py"
webkitpy.common.system.autoinstall: [DEBUG] Checking irclib.py URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/irc/.irclib.py.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for irclib.py already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://iweb.dl.sourceforge.net/project/python-irclib/python-irclib/0.4.8/python-irclib-0.4.8.zip"
webkitpy.common.system.autoinstall: [DEBUG] Checking ircbot.py URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/irc/.ircbot.py.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for ircbot.py already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://iweb.dl.sourceforge.net/project/python-irclib/python-irclib/0.4.8/python-irclib-0.4.8.zip"
webkitpy.common.system.autoinstall: [DEBUG] Checking mod_pywebsocket URL downloaded...
webkitpy.common.system.autoinstall: [DEBUG]     "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/autoinstalled/pywebsocket/.mod_pywebsocket.url"
webkitpy.common.system.autoinstall: [DEBUG] URL for mod_pywebsocket already downloaded.  Skipping...
webkitpy.common.system.autoinstall: [DEBUG]     "http://pywebsocket.googlecode.com/files/mod_pywebsocket-0.5.tar.gz"

This appears when running wekbit-patch --verbose.  Maybe I should make --verbose do differnet logging?  Or maybe we shouldn't be trying to load all those different autoinstalled urls?
Comment 1 Chris Jerdonek 2010-05-24 13:43:28 PDT
These types of messages are actually really good for debugging autoinstall.

Python's logging module is highly configurable.  Rather than changing autoinstall's code, the way to handle this type of issue is to be more fine-grained when configuring logging from other applications.  For example, you can use filters to disable autoinstall logging or to disable autoinstall logging below a certain level.  I.e. make the DEBUG apply to anything but autoinstall.

Let me see if I can dig up an example of filtering inside webkitpy.
Comment 2 Chris Jerdonek 2010-05-24 13:49:00 PDT
Check out this code which filters out autoinstall logging:

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/test-webkitpy?rev=56981#L87

I believe the webkitpy configure_logging() function you call at the beginning of webkit-patch accepts a filter parameter to add filters that the caller wants added.  If it doesn't, a parameter like that should probably be added.

Make sure you only filter autoinstall logging for DEBUG or below though -- I think the INFO messages are good to keep.
Comment 3 Chris Jerdonek 2010-05-24 14:10:34 PDT
(In reply to comment #0)
> Or maybe we shouldn't be trying to load all those different autoinstalled urls?

This report would address the above aspect of things:

https://bugs.webkit.org/show_bug.cgi?id=39223