Bug 39605 - restore r58765: notifications should have dir and replaceId attributes
Summary: restore r58765: notifications should have dir and replaceId attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 11:07 PDT by Dirk Pranke
Modified: 2010-05-25 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.88 KB, patch)
2010-05-24 11:08 PDT, Dirk Pranke 		dglazkov: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-05-24 11:07:48 PDT 
re-revert r58765
Comment 1 Dirk Pranke 2010-05-24 11:08:19 PDT 
Created attachment 56905 [details]
Patch
Comment 2 Dirk Pranke 2010-05-25 14:09:09 PDT 
Re-commit r58765 - it had been rolled out to see if it was causing a perf regression (in r59787 and r59789), but that does not seem to have been the case.

https://bugs.webkit.org/show_bug.cgi?id=38336 tracked the original bug ; https://bugs.webkit.org/show_bug.cgi?id=3928 tracked the revert.
Comment 3 Dimitri Glazkov (Google) 2010-05-25 14:09:57 PDT 
Comment on attachment 56905 [details]
Patch

ok.
Comment 4 Dirk Pranke 2010-05-25 15:48:03 PDT 
Committed r60193: <http://trac.webkit.org/changeset/60193>