Bug 39593 - [Android] Add IndexedDB to the build
Summary: [Android] Add IndexedDB to the build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-24 05:56 PDT by Jeremy Orlow
Modified: 2010-05-26 03:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.94 KB, patch)
2010-05-24 06:02 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (6.01 KB, patch)
2010-05-25 08:59 PDT, Jeremy Orlow 		steveblock: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-05-24 05:56:42 PDT 
[Android] Add IndexedDB to the build
Comment 1 Jeremy Orlow 2010-05-24 06:02:39 PDT 
Created attachment 56877 [details]
Patch
Comment 2 Jeremy Orlow 2010-05-25 07:20:06 PDT 
Ping..
Comment 3 Steve Block 2010-05-25 08:09:26 PDT 
Comment on attachment 56877 [details]
Patch

WebCore/Android.derived.jscbindings.mk:370
 +      $(intermediates)/storage/IndexedDatabaseRequest.h
These should be JSIDBFoo.h

WebCore/Android.derived.v8bindings.mk:351
 +      $(intermediates)/storage/IndexedDatabaseRequest.h
These should be bindings/V8IDBFoo.h

WebCore/Android.mk:730
 +  ifeq ($(ENABLE_INDEXED_DATABASE), true)
No need for the guards, as the file contents are guarded anyway (the SVG guards are just a legacy thing)
Comment 4 Jeremy Orlow 2010-05-25 08:59:19 PDT 
Created attachment 57023 [details]
Patch
Comment 5 Steve Block 2010-05-25 09:03:58 PDT 
Comment on attachment 57023 [details]
Patch

WebCore/Android.mk:739
 +  	storage/StorageSyncManager.cpp
Change not needed
Comment 6 Jeremy Orlow 2010-05-25 09:18:44 PDT 
(In reply to comment #5)
> (From update of attachment 57023 [details])
> WebCore/Android.mk:739
>  +      storage/StorageSyncManager.cpp
> Change not needed

Which is preferred?  I looked and saw at least a couple cases where there was none at the end, so I assumed that was preferred.
Comment 7 Steve Block 2010-05-25 09:23:43 PDT 
No trailing slash is preferred - just pointing out that this is no
longer required for your patch.
Comment 8 Jeremy Orlow 2010-05-25 09:26:20 PDT 
It's not clear from the diff, but that line is in the same block as the one I was adding to.  I just noticed it and figured I'd clean it up as I went.  It was never strictly required.  But I think it makes the world a slightly better place.
Comment 9 Jeremy Orlow 2010-05-26 03:35:57 PDT 
Committed r60228: <http://trac.webkit.org/changeset/60228>