RESOLVED FIXED 39585
Web Inspector: '?' and '/' typed at console prompt are not properly handled
https://bugs.webkit.org/show_bug.cgi?id=39585
Summary Web Inspector: '?' and '/' typed at console prompt are not properly handled
Andrey Kosyakov
Reported 2010-05-24 02:29:53 PDT
'?' and '/' invoke help screen even when typed at console prompt.
Attachments
patch (2.81 KB, patch)
2010-05-24 02:34 PDT, Andrey Kosyakov
yurys: review+
patch (2.83 KB, patch)
2010-05-24 02:49 PDT, Andrey Kosyakov
no flags
Andrey Kosyakov
Comment 1 2010-05-24 02:34:53 PDT
Yury Semikhatsky
Comment 2 2010-05-24 02:40:50 PDT
Comment on attachment 56865 [details] patch WebCore/inspector/front-end/inspector.js:715 + event.preventDefault(); why not return from here?
Andrey Kosyakov
Comment 3 2010-05-24 02:49:22 PDT
Created attachment 56867 [details] patch Indeed, we better return instantly upon catching our key. Thanks for spotting this -- it's been so for quite a few revisions!
Alexey Proskuryakov
Comment 4 2010-05-24 12:36:24 PDT
> '?' and '/' invoke help screen even when typed at console prompt. Why not mention that in ChangeLog? The current ChangeLog is super unhelpful - it tell neither what is fixed, nor how.
WebKit Commit Bot
Comment 5 2010-05-24 21:40:20 PDT
Comment on attachment 56867 [details] patch Clearing flags on attachment: 56867 Committed r60126: <http://trac.webkit.org/changeset/60126>
WebKit Commit Bot
Comment 6 2010-05-24 21:40:26 PDT
All reviewed patches have been landed. Closing bug.
Pavel Feldman
Comment 7 2010-05-28 03:20:55 PDT
*** Bug 39862 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.