RESOLVED FIXED 39575
Switch JS wrappers from inheriting from JSObject to inheriting from JSObjectWithGlobalObject 
https://bugs.webkit.org/show_bug.cgi?id=39575
Summary Switch JS wrappers from inheriting from JSObject to inheriting from JSObjectW...
Sam Weinig
Reported 2010-05-23 17:47:54 PDT
Now that JavaScriptCore has JSObjectWithGlobalObject, we should move off of DOMObjectWithGlobalPointer and onto it. This is the first step which makes DOMObject inherit from JSObjectWithGlobalObject but keeps DOMObjectWithGlobalPointer around. I will remove it and condense the inheritance hierarchy in a subsequent patch.
Attachments
patch (19.28 KB, patch)
2010-05-23 17:51 PDT, Sam Weinig 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-05-23 17:51:12 PDT
Created attachment 56839 [details] patch This still needs a change to the windows JSC exports file. Maybe the EWS bot will let me know what the correct mangled name is.
Oliver Hunt
Comment 2 2010-05-23 18:22:37 PDT
Comment on attachment 56839 [details] patch r=me
Sam Weinig
Comment 3 2010-05-23 19:15:52 PDT
Landed in r60057.
WebKit Review Bot
Comment 4 2010-05-23 19:40:16 PDT
http://trac.webkit.org/changeset/60057 might have broken Qt Linux ARMv5 Release
Eric Seidel (no email)
Comment 5 2010-05-23 19:56:59 PDT
No, the Qt builders just can't stay connected to save their lives.
Eric Seidel (no email)
Comment 6 2010-05-23 19:57:28 PDT
This is very exciting, btw!
WebKit Review Bot
Comment 7 2010-05-23 20:30:55 PDT
Attachment 56839 [details] did not build on win: Build output: http://webkit-commit-queue.appspot.com/results/2313549
Note You need to log in before you can comment on or make changes to this bug.