Bug 39575 - Switch JS wrappers from inheriting from JSObject to inheriting from JSObjectWithGlobalObject
Summary: Switch JS wrappers from inheriting from JSObject to inheriting from JSObjectW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-23 17:47 PDT by Sam Weinig
Modified: 2010-05-23 20:30 PDT (History)
4 users (show)

See Also:


Attachments
patch (19.28 KB, patch)
2010-05-23 17:51 PDT, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-05-23 17:47:54 PDT
Now that JavaScriptCore has JSObjectWithGlobalObject, we should move off of DOMObjectWithGlobalPointer and onto it.  This is the first step which makes DOMObject inherit from JSObjectWithGlobalObject but keeps DOMObjectWithGlobalPointer around.  I will remove it and condense the inheritance hierarchy in a subsequent patch.
Comment 1 Sam Weinig 2010-05-23 17:51:12 PDT
Created attachment 56839 [details]
patch

This still needs a change to the windows JSC exports file.  Maybe the EWS bot will let me know what the correct mangled name is.
Comment 2 Oliver Hunt 2010-05-23 18:22:37 PDT
Comment on attachment 56839 [details]
patch

r=me
Comment 3 Sam Weinig 2010-05-23 19:15:52 PDT
Landed in r60057.
Comment 4 WebKit Review Bot 2010-05-23 19:40:16 PDT
http://trac.webkit.org/changeset/60057 might have broken Qt Linux ARMv5 Release
Comment 5 Eric Seidel (no email) 2010-05-23 19:56:59 PDT
No, the Qt builders just can't stay connected to save their lives.
Comment 6 Eric Seidel (no email) 2010-05-23 19:57:28 PDT
This is very exciting, btw!
Comment 7 WebKit Review Bot 2010-05-23 20:30:55 PDT
Attachment 56839 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/2313549