[Qt] QtWebKit overwrites transparent wmode with opaque

In FrameLoaderClientQt.cpp, FrameLoaderClientQt::createPlugin.

The code for NPAPI plugins always overwrites wmode transparent with opaque. According to http://blog.forwardbias.in/2009/12, this may be helpful on X11. However on Mac and Windows it results in transparent plugins that would have rendered just fine, appearing opaque and resulting in visual errors or inaccessible video (vimeo.com).

I suggest adding an X11 condition like:

                if (wmodeIndex == -1) {
                    params.append("wmode");
                    values.append("opaque");
-                } else
+                } else {
+#ifdef Q_WS_X11
+                    // wmode=opaque only required on X11, http://blog.forwardbias.in/2009/12
                    values[wmodeIndex] = "opaque";
+#endif
+                }
            }
        }

[Benjamin Poulain]

Reviewers do not see patches if you do not submit them as patches. Here is how to submit a patch to WebKit: https://trac.webkit.org/wiki/QtWebKitContrib

[Viatcheslav Ostapenko]

*** This bug has been marked as a duplicate of bug 50495 ***