Created attachment 56824 [details] modified configure.ac The current configure script doesn't check the required GTK+ version to 2.18 If the installed GTK+ is prior to 2.18, you can see the following build break message. WebCore/platform/gtk/ScrollbarGtk.cpp:211: error: ‘gtk_widget_get_has_window’ was not declared in this scope gtk_widget_get_has_window API has been introduced since 2.18 Therefore we need to modify configure.ac as follows, diff --git a/configure.ac b/configure.ac index 9757541..a076e35 100644 --- a/configure.ac +++ b/configure.ac @@ -205,7 +205,7 @@ LIBXML_REQUIRED_VERSION=2.6 # minimum GTK+ base dependencies PANGO_REQUIRED_VERSION=1.12 -GTK_REQUIRED_VERSION=2.10 +GTK_REQUIRED_VERSION=2.18
(In reply to comment #0) > Created an attachment (id=56824) [details] > modified configure.ac > > The current configure script doesn't check the required GTK+ version to 2.18 > If the installed GTK+ is prior to 2.18, you can see the following build break message. > > WebCore/platform/gtk/ScrollbarGtk.cpp:211: error: ‘gtk_widget_get_has_window’ was not declared in this scope > > gtk_widget_get_has_window API has been introduced since 2.18 > Therefore we need to modify configure.ac as follows, > > diff --git a/configure.ac b/configure.ac > index 9757541..a076e35 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -205,7 +205,7 @@ LIBXML_REQUIRED_VERSION=2.6 > > # minimum GTK+ base dependencies > PANGO_REQUIRED_VERSION=1.12 > -GTK_REQUIRED_VERSION=2.10 > +GTK_REQUIRED_VERSION=2.18 The required GTK+ version is 2.10, not 2.18. If we fail to compile with it then it's just a mistake, not intentional. In the case of gtk_widget_get_has_window this should be fixed in WebCore/platform/gtk/GtkVersioning.h, so not sure what's going on. Are you using svn trunk?
I'm using git trunk. I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp
(In reply to comment #2) > I'm using git trunk. > > I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp That sounds right to me. Want to make a patch with a changelog? =)
(In reply to comment #2) > I'm using git trunk. > > I think that GtkVersioning.h should be included in WebCore/platform/gtk/ScrollbarGtk.cpp Duh, of course. As Gustavo says, a patch is welcome :)
Created attachment 57012 [details] Proposed patch Hi~ I made a patch. Thanks!
Comment on attachment 57012 [details] Proposed patch r=me
(In reply to comment #1) > The required GTK+ version is 2.10, not 2.18. If we fail to compile with it then it's just a mistake, not intentional. In the case of gtk_widget_get_has_window this should be fixed in WebCore/platform/gtk/GtkVersioning.h, so not sure what's going on. Are you using svn trunk? Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency.
Comment on attachment 57012 [details] Proposed patch Clearing flags on attachment: 57012 Committed r60288: <http://trac.webkit.org/changeset/60288>
All reviewed patches have been landed. Closing bug.
(In reply to comment #7) > Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency. I said exactly that some time ago, and someone then explained to me that the reason we try to support 2.10 is because that's what Maemo had, and people saw it as a good thing to have (given it was not too complex). Maemo5 has moved to GTK+ 2.14, it seems, so the reasons to support something older than 2.14 may soon be gone.
(In reply to comment #10) > (In reply to comment #7) > > Please have a look at #37085 where I try to explain why GTK+ versions < 2.18 are unlikely to be used in practice due to the high glib dependency. > > I said exactly that some time ago, and someone then explained to me that the reason we try to support 2.10 is because that's what Maemo had, and people saw it as a good thing to have (given it was not too complex). Maemo5 has moved to GTK+ 2.14, it seems, so the reasons to support something older than 2.14 may soon be gone. Supporting GTK+ 2.14 alone won't help you for Maemo. Maemo 5 ships with glib 2.20, and that is too old for the libsoup versions required by WebKitGTK+, and for WebKitGTK+ itself.