Bug 39552 - webkit-patch should let you add a comment when uploading a patch
Summary: webkit-patch should let you add a comment when uploading a patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-22 17:58 PDT by Adam Barth
Modified: 2010-05-23 15:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2010-05-22 17:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (4.28 KB, patch)
2010-05-23 14:09 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-05-22 17:58:31 PDT 
webkit-patch should let you add a comment when uploading a patch
Comment 1 Adam Barth 2010-05-22 17:59:32 PDT 
Created attachment 56802 [details]
Patch

Example comment
Comment 2 Daniel Bates 2010-05-22 18:00:47 PDT 
Comment on attachment 56802 [details]
Patch

Awesome! Looks good to me.
Comment 3 WebKit Commit Bot 2010-05-23 05:59:16 PDT 
Comment on attachment 56802 [details]
Patch

Rejecting patch 56802 from commit-queue.

Failed to run "['WebKitTools/Scripts/test-webkitpy']" exit_code: 1
Last 500 characters of output:
 --\nMOCK: user.open_url: http://example.com/42\n' != 'Running check-webkit-style\nMOCK: user.open_url: file://...\nObsoleting 2 old patches on bug 42\nMOCK add_patch_to_bug: bug_id=42, description=MOCK description, mark_for_review=True, mark_for_commit_queue=False, mark_for_landing=False\n-- Begin comment --\nNone\n-- End comment --\nMOCK: user.open_url: http://example.com/42\n'

----------------------------------------------------------------------
Ran 447 tests in 8.616s

FAILED (failures=2)

Full output: http://webkit-commit-queue.appspot.com/results/2298501
Comment 4 Adam Barth 2010-05-23 14:09:20 PDT 
Created attachment 56829 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-05-23 15:08:46 PDT 
Comment on attachment 56829 [details]
Patch for landing

Clearing flags on attachment: 56829

Committed r60050: <http://trac.webkit.org/changeset/60050>
Comment 6 WebKit Commit Bot 2010-05-23 15:08:51 PDT 
All reviewed patches have been landed.  Closing bug.