Bug 39547 - Add Galician translation to webkitgtk
Summary: Add Galician translation to webkitgtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-22 16:27 PDT by Fran Dieguez
Modified: 2010-06-25 03:02 PDT (History)
6 users (show)

See Also:


Attachments
Galician translation of webkitgtk (34.57 KB, text/x-gettext-translation)
2010-05-22 16:27 PDT, Fran Dieguez
no flags Details
Patch file to add galician translation to WebKit/gtk (35.85 KB, patch)
2010-05-24 01:02 PDT, Fran Dieguez
no flags Details | Formatted Diff | Diff
Patch (36.36 KB, patch)
2010-05-24 04:47 PDT, Fran Dieguez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fran Dieguez 2010-05-22 16:27:28 PDT
Created attachment 56795 [details]
Galician translation of webkitgtk

I have exported the webkitgtk pofile and made its translation to galician language. Please commit to repository and make it publicly accesible.
Comment 1 Dirk Schulze 2010-05-24 00:24:20 PDT
(In reply to comment #0)
> Created an attachment (id=56795) [details]
> Galician translation of webkitgtk
> 
> I have exported the webkitgtk pofile and made its translation to galician language. Please commit to repository and make it publicly accesible.

(In reply to comment #0)
> Created an attachment (id=56795) [details]
> Galician translation of webkitgtk
> 
> I have exported the webkitgtk pofile and made its translation to galician language. Please commit to repository and make it publicly accesible.

Please add the translation to the correct directory in WebKit/gtk, add it to your local repository and create a patch with a changelog. This patch can be reviewed here and commited by the commit bot.
Comment 2 Fran Dieguez 2010-05-24 01:02:21 PDT
Created attachment 56857 [details]
Patch file to add galician translation to WebKit/gtk
Comment 3 Fran Dieguez 2010-05-24 01:03:03 PDT
I attach the diff file that adds galician translation to WebKit/gtk/ directory.
Thanks for the tip
Comment 4 Dirk Schulze 2010-05-24 04:41:54 PDT
(In reply to comment #3)
> I attach the diff file that adds galician translation to WebKit/gtk/ directory.
> Thanks for the tip

You're nearly done :-) You forgot a log entry in WebKit/gtk/po/ChangeLog
A script will help you to do that. When you're in your local <webkit> directory, type the following:

  WebKitTools/Scripts/prepare-ChangeLog --bug 39547 --email=<your mail adress>

Open the ChangeLog in your editor, write a line that this will add galician translations. Another script can create a patch and upload the patch directly to this bug report and mark it for review (sets the review flag to  '?'):

  WebKitTools/Scripts/webkit-patch upload 39547

You just need to type your account name and password into the prompt when you get asked. (It can be that you get error messages when you use your local language settings in your bash, just type 'export LANG="C"' before using the scripts in this case).

Many thanks for your help and the work you've done.
Comment 5 Fran Dieguez 2010-05-24 04:47:13 PDT
Created attachment 56871 [details]
Patch
Comment 6 Fran Dieguez 2010-05-26 16:27:35 PDT
Is enough information?
I have summited the patch with your specs...
Comment 7 Fran Dieguez 2010-05-30 03:47:15 PDT
I have changed the Platform and OS parameters of this bugs cause this affects all the platforms
Comment 8 Dirk Schulze 2010-06-01 05:58:03 PDT
Kov, can you take a look at this? I don't have experiences in translations and gtk.
Comment 9 Darin Adler 2010-06-12 17:57:16 PDT
Comment on attachment 56871 [details]
Patch

Seems fine to add this. rs=me
Comment 10 WebKit Commit Bot 2010-06-25 02:24:35 PDT
Comment on attachment 56871 [details]
Patch

Clearing flags on attachment: 56871

Committed r61841: <http://trac.webkit.org/changeset/61841>
Comment 11 WebKit Commit Bot 2010-06-25 02:24:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Review Bot 2010-06-25 03:02:46 PDT
http://trac.webkit.org/changeset/61841 might have broken Leopard Intel Release (Tests)