Bug 39528 - Clean up continuations in preparation for column-span
Summary: Clean up continuations in preparation for column-span
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 21:03 PDT by Dave Hyatt
Modified: 2010-05-21 21:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch (30.84 KB, patch)
2010-05-21 21:04 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-05-21 21:03:23 PDT 
Clean up continuations in preparation for column-span
Comment 1 Dave Hyatt 2010-05-21 21:04:35 PDT 
Created attachment 56773 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-21 21:06:30 PDT 
Attachment 56773 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderBlock.cpp:544:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-05-21 21:16:29 PDT 
Comment on attachment 56773 [details]
Patch

WebCore/rendering/RenderObject.h:389
 +      bool isElementContinuation() const { return node() ? node()->renderer() != this : false; }
Can simply return node() && node()->renderer() != this;

Looks harmless :-)
Comment 4 Dave Hyatt 2010-05-21 21:23:34 PDT 
Fixed in r59988.