RESOLVED FIXED 39528
Clean up continuations in preparation for column-span 
https://bugs.webkit.org/show_bug.cgi?id=39528
Summary Clean up continuations in preparation for column-span
Dave Hyatt
Reported 2010-05-21 21:03:23 PDT
Clean up continuations in preparation for column-span
Attachments
Patch (30.84 KB, patch)
2010-05-21 21:04 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-05-21 21:04:35 PDT
Created attachment 56773 [details] Patch
WebKit Review Bot
Comment 2 2010-05-21 21:06:30 PDT
Attachment 56773 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/rendering/RenderBlock.cpp:544: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2010-05-21 21:16:29 PDT
Comment on attachment 56773 [details] Patch WebCore/rendering/RenderObject.h:389 + bool isElementContinuation() const { return node() ? node()->renderer() != this : false; } Can simply return node() && node()->renderer() != this; Looks harmless :-)
Dave Hyatt
Comment 4 2010-05-21 21:23:34 PDT
Fixed in r59988.
Note You need to log in before you can comment on or make changes to this bug.