Bug 39517 - [Qt] GraphicsLayer: The rocket animation doesn't scroll together with the page
Summary: [Qt] GraphicsLayer: The rocket animation doesn't scroll together with the page
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://www.the-art-of-web.com/css/css...
Keywords: Qt
Depends on:
Blocks: 38744
  Show dependency tree / graph
 
Reported: 2010-05-21 16:28 PDT by Noam Rosenthal
Modified: 2010-06-10 01:22 PDT (History)
4 users (show)

See Also:

Attachments
Fix (1.21 KB, patch)
2010-05-21 16:49 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-05-21 16:28:48 PDT 
it only scrolls after the animation is over
Comment 1 Noam Rosenthal 2010-05-21 16:49:24 PDT 
Created attachment 56762 [details]
Fix
Comment 2 Kenneth Rohde Christiansen 2010-05-22 08:09:42 PDT 
Jesus, your refactoring broke this.
Comment 3 WebKit Commit Bot 2010-05-23 05:10:23 PDT 
Comment on attachment 56762 [details]
Fix

Clearing flags on attachment: 56762

Committed r60041: <http://trac.webkit.org/changeset/60041>
Comment 4 WebKit Commit Bot 2010-05-23 05:10:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-05-25 01:53:55 PDT 
As far as I can see this is a regression introduced in r59152, which appears to have removed the call to updateCompositingScrollPosition().

Since 59152 wasn't cherry-picked into the release branch, the patch for this bug doesn't apply. However pre-59152 - i.e. with what's in the 2.0 branch - the call to updateCompositionScrollPosition() is there but it happens before calling syncLayers().

Is this analysis correct?

What's the right thing to do for 2.0? Keep it as is? Move the call to after syncLayers(), like in the trunk?
Comment 6 Kenneth Rohde Christiansen 2010-05-25 05:23:17 PDT 
If the rocket animation scrolls together with the page, I say you need to do nothing.
Comment 7 Noam Rosenthal 2010-05-25 07:50:20 PDT 
It doesn't matter - the implementations are interchangeable. I agree with Kenneth...
Comment 8 Simon Hausmann 2010-06-07 03:16:16 PDT 
Fixed url to testcase
Comment 9 Simon Hausmann 2010-06-07 03:22:19 PDT 
(In reply to comment #6)
> If the rocket animation scrolls together with the page, I say you need to do nothing.

I assume with "scroll together" you mean scrolling the page with the wheel should work fine while the animation is running?
Comment 10 Kenneth Rohde Christiansen 2010-06-07 05:28:30 PDT 
(In reply to comment #9)
> (In reply to comment #6)
> > If the rocket animation scrolls together with the page, I say you need to do nothing.
> 
> I assume with "scroll together" you mean scrolling the page with the wheel should work fine while the animation is running?

Exactly.
Comment 11 Simon Hausmann 2010-06-07 07:03:21 PDT 
Good, since that worked I'll remove it from the blockers. No picking necessary :)