Bug 39516 - Add support for parsing the column-span property and getting it into computed style.
Summary: Add support for parsing the column-span property and getting it into computed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 15:38 PDT by Dave Hyatt
Modified: 2010-05-25 13:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.44 KB, patch)
2010-05-21 15:40 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-05-21 15:38:59 PDT 
Back end support for column-span.
Comment 1 Dave Hyatt 2010-05-21 15:40:05 PDT 
Created attachment 56756 [details]
Patch
Comment 2 WebKit Review Bot 2010-05-21 15:41:45 PDT 
Attachment 56756 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/css/CSSParser.cpp:1489:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2010-05-21 15:43:14 PDT 
Comment on attachment 56756 [details]
Patch

WebCore/css/CSSParser.cpp:1493
 +              validPrimitive = validUnit(value, FNumber | FNonNeg, m_strict) && value->fValue == 1.0;
Current style for this is “1” instead of “1.0”.

r=me
Comment 4 Dave Hyatt 2010-05-21 15:46:11 PDT 
Fixed in r59968.
Comment 5 WebKit Review Bot 2010-05-21 16:24:32 PDT 
http://trac.webkit.org/changeset/59968 might have broken GTK Linux 32-bit Release
Comment 6 Darin Adler 2010-05-25 13:45:52 PDT 
This patch didn’t include a ChangeLog for the LayoutTests directory and only updated the Mac-specific expected results for the getComputedStyle test. I am landing a fix for the rest.