Bug 39512 - Fix code generators to better support Conditional attribute and add test coverage for it
Summary: Fix code generators to better support Conditional attribute and add test cove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 13:57 PDT by Jian Li
Modified: 2010-06-14 11:35 PDT (History)
5 users (show)

See Also:


Attachments
Proposed Patch (41.66 KB, patch)
2010-05-21 14:20 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (44.99 KB, patch)
2010-05-24 10:59 PDT, Jian Li
darin: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-05-21 13:57:05 PDT
Some code generators do not support Conditional extended attribute completely. We also need to ass the test coverage for it.
Comment 1 Jian Li 2010-05-21 14:20:13 PDT
Created attachment 56746 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2010-05-21 14:22:46 PDT
Attachment 56746 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
arens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:721:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:727:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:734:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:741:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:817:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:823:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:830:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:837:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:950:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:960:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:971:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:982:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 36 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2010-05-21 16:23:16 PDT
Attachment 56746 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/2266404
Comment 4 Eric Seidel (no email) 2010-05-24 01:10:27 PDT
Gtk failure?
DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:5: warning: "ENABLE" is not defined
DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:11: error: missing binary operator before token "("
Comment 5 Jian Li 2010-05-24 10:59:36 PDT
Created attachment 56904 [details]
Proposed Patch

Fixed GTK error.
Comment 6 WebKit Review Bot 2010-05-24 11:00:41 PDT
Attachment 56904 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
arens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:601:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:722:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:729:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:736:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:742:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:818:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:825:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:832:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:838:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:951:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:962:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:973:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:983:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 36 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jian Li 2010-06-14 11:35:48 PDT
Committed as http://trac.webkit.org/changeset/61131.