Some code generators do not support Conditional extended attribute completely. We also need to ass the test coverage for it.
Created attachment 56746 [details] Proposed Patch
Attachment 56746 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 Last 3072 characters of output: arens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:600: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:741: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:817: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:823: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:830: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:837: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:971: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:982: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 36 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 56746 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/2266404
Gtk failure? DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:5: warning: "ENABLE" is not defined DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:11: error: missing binary operator before token "("
Created attachment 56904 [details] Proposed Patch Fixed GTK error.
Attachment 56904 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 Last 3072 characters of output: arens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:601: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:722: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:818: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:838: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:951: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:973: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:983: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 36 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed as http://trac.webkit.org/changeset/61131.