39512 – Fix code generators to better support Conditional attribute and add test coverage for it

RESOLVED FIXED 39512

Fix code generators to better support Conditional attribute and add test coverage for it

https://bugs.webkit.org/show_bug.cgi?id=39512

Summary Fix code generators to better support Conditional attribute and add test cove...

Jian Li

Reported 2010-05-21 13:57:05 PDT

Some code generators do not support Conditional extended attribute completely. We also need to ass the test coverage for it.

Attachments
Proposed Patch (41.66 KB, patch) 2010-05-21 14:20 PDT, Jian Li	jianli: commit-queue-	Details Formatted Diff Diff
Proposed Patch (44.99 KB, patch) 2010-05-24 10:59 PDT, Jian Li	darin: review+ jianli: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2010-05-21 14:20:13 PDT

Created attachment 56746 [details] Proposed Patch

WebKit Review Bot

Comment 2 2010-05-21 14:22:46 PDT

Attachment 56746 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 Last 3072 characters of output: arens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:600: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:721: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:734: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:741: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:817: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:823: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:830: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:837: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:950: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:960: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:971: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:982: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 36 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2010-05-21 16:23:16 PDT

Attachment 56746 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/2266404

Eric Seidel (no email)

Comment 4 2010-05-24 01:10:27 PDT

Gtk failure? DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:5: warning: "ENABLE" is not defined DerivedSources/webkit/WebKitDOMDOMApplicationCache.cpp:21:11: error: missing binary operator before token "("

Jian Li

Comment 5 2010-05-24 10:59:36 PDT

Created attachment 56904 [details] Proposed Patch Fixed GTK error.

WebKit Review Bot

Comment 6 2010-05-24 11:00:41 PDT

Attachment 56904 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 Last 3072 characters of output: arens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:601: Extra space before ( in function call [whitespace/parens] [4] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:722: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:729: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:742: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:818: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:824: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:825: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:831: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:832: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:838: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:951: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:972: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:973: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:983: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 36 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jian Li

Comment 7 2010-06-14 11:35:48 PDT

Committed as http://trac.webkit.org/changeset/61131.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Tools / Tests

Assignee

Jian Li

Reported

2010-05-21 13:57 PDT

Modified

2010-06-14 11:35 PDT History

CC List

5 users Show

URL

Keywords

Depends on

Blocks