Bug 39503 – incorrect selection with absolutely positioned div.

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ojan Vafai]

Created attachment 56732 [details]
test case

See the test case.

[Ryosuke Niwa]

The problem is that RenderBlock::positionForPoint assumes that the lastChildBox is not positioned.

if (lastChildBox() && contentsY > lastChildBox()->y()) { 
    for (RenderBox* childBox = lastChildBox(); childBox; childBox = childBox->previousSiblingBox()) { 
        if (isChildHitTestCandidate(childBox)) 
            return positionForPointRespectingEditingBoundaries(this, childBox, pointInContents); 
    } 
} else { 

+mitz since this code was added in http://trac.webkit.org/changeset/42467.

[Ryosuke Niwa]

Created attachment 107921 [details]
fixes the bug

[Ryosuke Niwa]

Comment on attachment 107921 [details]
fixes the bug

Oops, something's wrong with my patch.

[Kenneth Rohde Christiansen]

> LayoutTests/ChangeLog:9
> +        with a absolutely positioned last child. WebKit should place the caret on the left of the first line

I guess it is "an absolutely"

[Ryosuke Niwa]

Comment on attachment 107921 [details]
fixes the bug

Nope. My patch is fine. I was commenting out some code to verify my test and had forgotten to rebuild before running the test.

[Kenneth Rohde Christiansen]

Comment on attachment 107921 [details]
fixes the bug

Nice test and good catch, r=me

[Ryosuke Niwa]

(In reply to comment #6)
> (From update of attachment 107921 [details])
> Nice test and good catch, r=me

Thanks for the review! WIll fix "a absolutely".

[Ryosuke Niwa]

Committed r95478: <http://trac.webkit.org/changeset/95478>