RESOLVED FIXED 39502
Clean up RenderLayerBacking code that looks for the body 
https://bugs.webkit.org/show_bug.cgi?id=39502
Summary Clean up RenderLayerBacking code that looks for the body
Simon Fraser (smfr)
Reported 2010-05-21 11:15:32 PDT
hyatt : smfr: there's code that is trying to look for the <body> background [11:12am ]dethbakin : hyatt: yeah, that' a horrible hack [11:12am ]hyatt : smfr: and you do it by trying to grab the first child of the root renderer [11:13am ]hyatt : smfr: but there's a nice clean way to obtain the body renderer [11:13am ]smfr : hyatt: it's probably wrong; dino copied it from somewhere [11:13am ]hyatt : document()->body()->renderer() [11:13am ]smfr : k [11:13am ]hyatt : (body() can be 0 of course) [11:13am ]hyatt : smfr: it's perfectly legal to do this: [11:13am ]hyatt : <head style="display:block"> [11:13am ]hyatt : <title style="display:block">Yo [11:13am ]hyatt : </head> [11:13am ]hyatt : <body> [11:13am ]hyatt : Also yo [11:13am ]hyatt : so getting the firstChild is just wrong
Attachments
Patch (13.26 KB, patch)
2012-01-10 12:30 PST, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-01-10 12:30:44 PST
Created attachment 121890 [details] Patch
Dave Hyatt
Comment 2 2012-01-10 13:12:57 PST
Comment on attachment 121890 [details] Patch r=me
Simon Fraser (smfr)
Comment 3 2012-01-10 13:38:58 PST
http://trac.webkit.org/changeset/104628
Note You need to log in before you can comment on or make changes to this bug.